Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 1925583002: Check the state of the current binary op IC before patching smi code (Closed)

Created:
4 years, 7 months ago by Toon Verwaest
Modified:
4 years, 7 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Check the state of the current binary op IC before patching smi code Between the miss and patching, we run user code. That may already patch the same code. IC refactoring broke this (again), so including a regression test this time around. BUG=chromium:601392 LOG=n Committed: https://crrev.com/f1cc6e646f939ba177e50fd5b5137c486ee4fdac Cr-Commit-Position: refs/heads/master@{#35811}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -11 lines) Patch
M src/ic/ic.cc View 2 chunks +8 lines, -8 lines 0 comments Download
A + test/mjsunit/regress/regress-recurse-patch-binary-op.js View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Toon Verwaest
ptal
4 years, 7 months ago (2016-04-27 08:15:33 UTC) #2
Igor Sheludko
lgtm
4 years, 7 months ago (2016-04-27 08:48:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1925583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1925583002/1
4 years, 7 months ago (2016-04-27 08:51:23 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-27 09:16:42 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-04-27 09:19:21 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f1cc6e646f939ba177e50fd5b5137c486ee4fdac
Cr-Commit-Position: refs/heads/master@{#35811}

Powered by Google App Engine
This is Rietveld 408576698