Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(786)

Issue 1925563003: Revert of [heap] Uncommit pooled pages concurrently (Closed)

Created:
4 years, 7 months ago by Michael Hablich
Modified:
4 years, 7 months ago
CC:
Hannes Payer (out of office), ulan, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Uncommit pooled pages concurrently (patchset #5 id:120001 of https://codereview.chromium.org/1913083002/ ) Reason for revert: Creates a spike of OOM(v8) crashers on Win32. Original issue's description: > [heap] Uncommit pooled pages concurrently > > - Move the concurrent unmapping to MemoryAllocator > - Hide (private) members where possible > - MemoryAllocator:Free is now the bottleneck for freeing > - Pooled pages are either allocated from a set of pooled pages are obtained > through work stealing from the concurrent unmapper > > BUG=chromium:605866, chromium:581412 > LOG=N > > Committed: https://crrev.com/2158df87116906160cebc3ad20c97f454822da03 > Cr-Commit-Position: refs/heads/master@{#35797} TBR=hpayer@chromium.org,mlippautz@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:605866, chromium:581412 Committed: https://crrev.com/25ff296c4c8d35c63255531a86f877f20eeaeb62 Cr-Commit-Position: refs/heads/master@{#35819}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -216 lines) Patch
M src/deoptimizer.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/heap.h View 3 chunks +12 lines, -0 lines 0 comments Download
M src/heap/heap.cc View 3 chunks +74 lines, -0 lines 0 comments Download
M src/heap/mark-compact.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/heap/spaces.h View 6 chunks +18 lines, -96 lines 0 comments Download
M src/heap/spaces.cc View 14 chunks +46 lines, -115 lines 0 comments Download
M test/cctest/heap/test-spaces.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Michael Hablich
Created Revert of [heap] Uncommit pooled pages concurrently
4 years, 7 months ago (2016-04-27 12:39:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1925563003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1925563003/1
4 years, 7 months ago (2016-04-27 12:39:22 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-27 12:39:36 UTC) #3
commit-bot: I haz the power
4 years, 7 months ago (2016-04-27 12:40:16 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/25ff296c4c8d35c63255531a86f877f20eeaeb62
Cr-Commit-Position: refs/heads/master@{#35819}

Powered by Google App Engine
This is Rietveld 408576698