Chromium Code Reviews

Issue 1925543003: MIPS: Fix unbounded label counter. (Closed)

Created:
4 years, 7 months ago by balazs.kilvady
Modified:
4 years, 7 months ago
Reviewers:
ivica.bogosavljevic, miran.karic, Marija Antic, gergely.kis.imgtec, akos.palfi.imgtec
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Fix unbounded label counter. TEST=mjsunit/asm/embenchen/zlib BUG= Committed: https://crrev.com/5345727935ad47b56aa43dece35effa511055df6 Cr-Commit-Position: refs/heads/master@{#35854}

Patch Set 1 #

Patch Set 2 : Fix tests. #

Unified diffs Side-by-side diffs Stats (+10 lines, -0 lines)
M src/mips/assembler-mips.h View 1 chunk +2 lines, -0 lines 0 comments
M src/mips/assembler-mips.cc View 1 chunk +1 line, -0 lines 0 comments
M src/mips64/assembler-mips64.h View 1 chunk +2 lines, -0 lines 0 comments
M src/mips64/assembler-mips64.cc View 1 chunk +1 line, -0 lines 0 comments
M test/cctest/test-assembler-mips.cc View 1 chunk +2 lines, -0 lines 0 comments
M test/cctest/test-assembler-mips64.cc View 1 chunk +2 lines, -0 lines 0 comments

Messages

Total messages: 9 (4 generated)
balazs.kilvady
4 years, 7 months ago (2016-04-27 18:11:22 UTC) #2
akos.palfi.imgtec
lgtm
4 years, 7 months ago (2016-04-27 18:33:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1925543003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1925543003/20001
4 years, 7 months ago (2016-04-28 10:31:45 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-04-28 10:58:51 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-01 22:02:06 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/5345727935ad47b56aa43dece35effa511055df6
Cr-Commit-Position: refs/heads/master@{#35854}

Powered by Google App Engine