third_party/WebKit/Source/platform/graphics/Image.h - Issue 1925533003: High CPU and increased memory usage fix for high-res (GIF, WEBP...) animations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/Image.h

Issue 1925533003: High CPU and increased memory usage fix for high-res (GIF, WEBP...) animations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: @scroggo, thanks a lot - this makes page [3] to use 250MB (was 750MB) Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/graphics/FrameData.cpp ('K') | « third_party/WebKit/Source/platform/graphics/GeneratedImage.h ('k') | third_party/WebKit/Source/platform/graphics/ImageLayerChromiumTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/Image.h

diff --git a/third_party/WebKit/Source/platform/graphics/Image.h b/third_party/WebKit/Source/platform/graphics/Image.h

index 412b355d820997d9cfa4a9079f2ce62557d6d8ca..24a0fc04770f01a148aefc1f77727fc2d33c8aa8 100644

--- a/third_party/WebKit/Source/platform/graphics/Image.h

+++ b/third_party/WebKit/Source/platform/graphics/Image.h

@@ -104,7 +104,7 @@ public:

virtual String filenameExtension() const { return String(); } // null string if unknown

- virtual void destroyDecodedData(bool destroyAll) = 0;

+ virtual void destroyDecodedData() = 0;

SharedBuffer* data() { return m_encodedImageData.get(); }

@@ -112,7 +112,6 @@ public:

// It will automatically pause once all observers no longer want to render the image anywhere.

enum CatchUpAnimation { DoNotCatchUp, CatchUp };

virtual void startAnimation(CatchUpAnimation = CatchUp) { }

- virtual void stopAnimation() {}

virtual void resetAnimation() {}

// True if this image can potentially animate.