Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(862)

Unified Diff: third_party/WebKit/Source/platform/graphics/FrameData.cpp

Issue 1925533003: High CPU and increased memory usage fix for high-res (GIF, WEBP...) animations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: @scroggo, thanks a lot - this makes page [3] to use 250MB (was 750MB) Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/FrameData.cpp
diff --git a/third_party/WebKit/Source/platform/graphics/FrameData.cpp b/third_party/WebKit/Source/platform/graphics/FrameData.cpp
index b510aa935bccb53d3144cc6f4a3e9a5ac7cb0e2e..3edfe4f745baada4d323a970118b43745df95249 100644
--- a/third_party/WebKit/Source/platform/graphics/FrameData.cpp
+++ b/third_party/WebKit/Source/platform/graphics/FrameData.cpp
@@ -43,19 +43,13 @@ FrameData::~FrameData()
clear(true);
}
-bool FrameData::clear(bool clearMetadata)
+void FrameData::clear(bool clearMetadata)
{
if (clearMetadata)
m_haveMetadata = false;
Peter Kasting 2016/05/04 03:01:07 I wonder if m_haveMetadata buys much anymore. See
Peter Kasting 2016/05/07 01:58:29 Did you have any thoughts on all this?
aleksandar.stojiljkovic 2016/05/07 19:50:53 I agree that current m_haveMetadata is better than
m_orientation = DefaultImageOrientation;
m_frameBytes = 0;
-
- if (m_frame) {
- m_frame.clear();
- return true;
- }
- return false;
}
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698