Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(843)

Unified Diff: third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.h

Issue 1925533003: High CPU and increased memory usage fix for high-res (GIF, WEBP...) animations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: @scroggo, thanks a lot - this makes page [3] to use 250MB (was 750MB) Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.h
diff --git a/third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.h b/third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.h
index d6084c91d47c542ff2caad1b7e16f2d693c3c3c3..5bc593ae51ca0bf1c1d4986f97745bf4acfa1a54 100644
--- a/third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.h
+++ b/third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.h
@@ -43,7 +43,7 @@ namespace blink {
class ImageFrameGenerator;
class SharedBuffer;
-struct FrameData;
+struct DeferredFrameData;
class PLATFORM_EXPORT DeferredImageDecoder final {
WTF_MAKE_NONCOPYABLE(DeferredImageDecoder);
@@ -87,7 +87,7 @@ private:
void activateLazyDecoding();
void prepareLazyDecodedFrames();
- PassRefPtr<SkImage> createFrameImageAtIndex(size_t index, bool knownToBeOpaque) const;
+ PassRefPtr<SkImage> createFrameImageAtIndex(size_t index, bool knownToBeOpaque);
// Copy of the data that is passed in, used by deferred decoding.
// Allows creating readonly snapshots that may be read in another thread.
@@ -102,7 +102,7 @@ private:
bool m_canYUVDecode;
// Carries only frame state and other information. Does not carry bitmap.
Peter Kasting 2016/05/04 03:01:07 This comment seems superfluous given that it's no
aleksandar.stojiljkovic 2016/05/04 20:56:29 Done.
- Vector<FrameData> m_frameData;
+ Vector<DeferredFrameData> m_frameData;
RefPtr<ImageFrameGenerator> m_frameGenerator;
static bool s_enabled;

Powered by Google App Engine
This is Rietveld 408576698