third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.h - Issue 1925533003: High CPU and increased memory usage fix for high-res (GIF, WEBP...) animations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.h

Issue 1925533003: High CPU and increased memory usage fix for high-res (GIF, WEBP...) animations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Beter approach (use same uniqueId for same SkImage) - thanks @pkasting. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.cpp ('k') | third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp » ('j') | third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.h

diff --git a/third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.h b/third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.h

index d6084c91d47c542ff2caad1b7e16f2d693c3c3c3..5bc593ae51ca0bf1c1d4986f97745bf4acfa1a54 100644

--- a/third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.h

+++ b/third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.h

@@ -43,7 +43,7 @@ namespace blink {

class ImageFrameGenerator;

class SharedBuffer;

-struct FrameData;

+struct DeferredFrameData;

class PLATFORM_EXPORT DeferredImageDecoder final {

WTF_MAKE_NONCOPYABLE(DeferredImageDecoder);

@@ -87,7 +87,7 @@ private:

void activateLazyDecoding();

void prepareLazyDecodedFrames();

- PassRefPtr<SkImage> createFrameImageAtIndex(size_t index, bool knownToBeOpaque) const;

+ PassRefPtr<SkImage> createFrameImageAtIndex(size_t index, bool knownToBeOpaque);

// Copy of the data that is passed in, used by deferred decoding.

// Allows creating readonly snapshots that may be read in another thread.

@@ -102,7 +102,7 @@ private:

bool m_canYUVDecode;

// Carries only frame state and other information. Does not carry bitmap.

- Vector<FrameData> m_frameData;

+ Vector<DeferredFrameData> m_frameData;

RefPtr<ImageFrameGenerator> m_frameGenerator;

static bool s_enabled;