third_party/WebKit/Source/core/svg/graphics/SVGImage.h - Issue 1925533003: High CPU and increased memory usage fix for high-res (GIF, WEBP...) animations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/graphics/SVGImage.h

Issue 1925533003: High CPU and increased memory usage fix for high-res (GIF, WEBP...) animations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Nits related to review #31 Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/ImageQualityControllerTest.cpp ('k') | third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp » ('j') | third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/svg/graphics/SVGImage.h

diff --git a/third_party/WebKit/Source/core/svg/graphics/SVGImage.h b/third_party/WebKit/Source/core/svg/graphics/SVGImage.h

index bc718d0911ea1faf03f8cc94662052ac348d4339..12089d9c8b00120dbcf7c8ff2f4301da74dfffdd 100644

--- a/third_party/WebKit/Source/core/svg/graphics/SVGImage.h

+++ b/third_party/WebKit/Source/core/svg/graphics/SVGImage.h

@@ -60,7 +60,6 @@ public:

bool currentFrameHasSingleSecurityOrigin() const override;

void startAnimation(CatchUpAnimation = CatchUp) override;

- void stopAnimation() override;

void resetAnimation() override;

// Advances an animated image. This will trigger an animation update for CSS

@@ -104,7 +103,7 @@ private:

// FIXME: SVGImages are underreporting decoded sizes and will be unable

// to prune because these functions are not implemented yet.

- void destroyDecodedData(bool) override { }

+ void destroyDecodedData() override { }

// FIXME: Implement this to be less conservative.

bool currentFrameKnownToBeOpaque(MetadataMode = UseCurrentMetadata) override { return false; }