High CPU and increased memory usage fix for high-res (GIF, WEBP...) animations.

third_party/WebKit/Source/platform/graphics/FrameData.h

 /*
  * Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com)
  * Copyright (C) 2004, 2005, 2006 Apple Computer, Inc.  All rights reserved.
  * Copyright (C) 2008-2009 Torch Mobile, Inc.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
@@ skipping 11 matching lines @@
  * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
  * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef FrameData_h
 #define FrameData_h
 
 #include "platform/graphics/ImageOrientation.h"
-#include "third_party/skia/include/core/SkImage.h"
 #include "wtf/Allocator.h"
 #include "wtf/Noncopyable.h"
 #include "wtf/RefPtr.h"
 #include "wtf/VectorTraits.h"
 
 namespace blink {
 
 struct FrameData {
     DISALLOW_NEW_EXCEPT_PLACEMENT_NEW();
     WTF_MAKE_NONCOPYABLE(FrameData);
 public:
     FrameData();
     ~FrameData();
 
     // Clear the cached image data on the frame, and (optionally) the metadata.
     // Returns whether there was cached image data to clear.
-    bool clear(bool clearMetadata);
+    void clear(bool clearMetadata);
 
-    RefPtr<SkImage> m_frame;
     ImageOrientation m_orientation;
     float m_duration;
     bool m_haveMetadata : 1;
     bool m_isComplete : 1;
     bool m_hasAlpha : 1;

[Peter Kasting, 2016/05/04 03:01:07]

While here: I'm slightly skeptical the memory savings from packing the bits
matter.  Do we really have so many FrameDatas sitting around at one time that
the bytes we save here add up to anything?  I would think the perf cost of
setting/reading individual bits would be a bigger deal than the memory savings
(though probably those are miniscule as well).

[aleksandar.stojiljkovic, 2016/05/04 20:56:29]

Often there are GIfs with 100+ frames, ig having e.g. 10 of those per page -
8KB. I've seen patches adding this on purpose to other files, too.

     size_t m_frameBytes;
 };
 
 } // namespace blink
 
 namespace WTF {
 template<> struct VectorTraits<blink::FrameData> : public SimpleClassVectorTraits<blink::FrameData> {
     STATIC_ONLY(VectorTraits);
     static const bool canInitializeWithMemset = false; // Not all FrameData members initialize to 0.
 };
 }
 
 #endif // FrameData_h