Redefine Ozone AcceleratedWidget as int32_t.

Redefine Ozone AcceleratedWidget as int32_t.

Ozone's AcceleratedWidget was defined as intptr_t, and then used "raw"
as gfx::SurfaceHandle in IPCs, triggering build-time IPC sanity-check
failures.

Defining it as int32_t passes the sanity-check and helps ensure that no
new code tries to put actual pointers in there by mistake.

BUG=607014
Committed: https://crrev.com/af126a587f99d80a7a42bcfc4b76cffb3e78d974
Cr-Commit-Position: refs/heads/master@{#390219}

[Wez, 2016-04-27 00:34:24]

wez@chromium.org changed reviewers:
+ spang@chromium.org

[Wez, 2016-04-27 00:34:24]

PTAL

[spang, 2016-04-27 00:45:23]

lgtm

[Wez, 2016-04-27 00:53:41]

From discussion on the bug, sounds like this should be switched to int64_t
to appease Ozone/X11 builds?

On 26 April 2016 at 17:45, <spang@chromium.org> wrote:

> lgtm
>
>
>
> https://codereview.chromium.org/1925483003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[spang, 2016-04-27 01:24:57]

On 2016/04/27 00:53:41, Wez wrote:
> From discussion on the bug, sounds like this should be switched to int64_t
> to appease Ozone/X11 builds?

Up to you, the point about X wire format being 32 bits seems pretty convincing
that this is fine for X as well.

> 
> On 26 April 2016 at 17:45, <mailto:spang@chromium.org> wrote:
> 
> > lgtm
> >
> >
> >
> > https://codereview.chromium.org/1925483003/
> >
> 
> -- 
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

[Wez, 2016-04-27 16:08:30]

The CQ bit was checked by wez@chromium.org

[commit-bot: I haz the power, 2016-04-27 16:08:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1925483003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1925483003/1

[commit-bot: I haz the power, 2016-04-27 16:20:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-27 16:20:26]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Wez, 2016-04-27 21:10:51]

wez@chromium.org changed reviewers:
+ danakj@chromium.org

[Wez, 2016-04-27 21:10:51]

+danakj: OWNERS plz!

[danakj, 2016-04-27 21:57:59]

LGTM

[Wez, 2016-04-27 22:28:28]

The CQ bit was checked by wez@chromium.org

[commit-bot: I haz the power, 2016-04-27 22:29:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1925483003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1925483003/1

[commit-bot: I haz the power, 2016-04-27 22:33:57]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-30 17:14:03]

Patchset 1 (id:??) landed as
https://crrev.com/af126a587f99d80a7a42bcfc4b76cffb3e78d974
Cr-Commit-Position: refs/heads/master@{#390219}

[commit-bot: I haz the power, 2016-04-30 17:52:32]

Description was changed from

==========
Redefine Ozone AcceleratedWidget as int32_t.

Ozone's AcceleratedWidget was defined as intptr_t, and then used "raw"
as gfx::SurfaceHandle in IPCs, triggering build-time IPC sanity-check
failures.

Defining it as int32_t passes the sanity-check and helps ensure that no
new code tries to put actual pointers in there by mistake.

BUG=607014
==========

to

==========
Redefine Ozone AcceleratedWidget as int32_t.

Ozone's AcceleratedWidget was defined as intptr_t, and then used "raw"
as gfx::SurfaceHandle in IPCs, triggering build-time IPC sanity-check
failures.

Defining it as int32_t passes the sanity-check and helps ensure that no
new code tries to put actual pointers in there by mistake.

BUG=607014

Committed: https://crrev.com/af126a587f99d80a7a42bcfc4b76cffb3e78d974
Cr-Commit-Position: refs/heads/master@{#390219}
==========