content/browser/accessibility/browser_accessibility_manager_mac.mm - Issue 1925473002: Add verbose logging for native accessibility events.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility_manager_mac.mm

Issue 1925473002: Add verbose logging for native accessibility events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@load_complete

Patch Set: address all feedback Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/browser_accessibility_manager_mac.h ('k') | content/browser/accessibility/browser_accessibility_manager_win.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/browser_accessibility_manager_mac.mm

diff --git a/content/browser/accessibility/browser_accessibility_manager_mac.mm b/content/browser/accessibility/browser_accessibility_manager_mac.mm

index 097eb4479097b51c2c9ffa1212571e19b11edb68..d45e0c28e6cea7ecc21d7697c734f8e75515fdb0 100644

--- a/content/browser/accessibility/browser_accessibility_manager_mac.mm

+++ b/content/browser/accessibility/browser_accessibility_manager_mac.mm

@@ -141,6 +141,7 @@ BrowserAccessibility* BrowserAccessibilityManagerMac::GetFocus() {

}

void BrowserAccessibilityManagerMac::NotifyAccessibilityEvent(

+ BrowserAccessibilityEvent::Source source,

ui::AXEvent event_type,

BrowserAccessibility* node) {

if (!node->IsNative())

@@ -393,7 +394,10 @@ void BrowserAccessibilityManagerMac::OnAtomicUpdateFinished(

static_cast<BrowserAccessibilityMac*>(GetRoot());

if (root) {

root->RecreateNativeObject();

- NotifyAccessibilityEvent(ui::AX_EVENT_CHILDREN_CHANGED, root);

+ NotifyAccessibilityEvent(

+ BrowserAccessibilityEvent::FromTreeChange,

+ ui::AX_EVENT_CHILDREN_CHANGED,

+ root);

}