Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Unified Diff: content/browser/accessibility/browser_accessibility_manager.h

Issue 1925473002: Add verbose logging for native accessibility events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@load_complete
Patch Set: address all feedback Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/accessibility/browser_accessibility_manager.h
diff --git a/content/browser/accessibility/browser_accessibility_manager.h b/content/browser/accessibility/browser_accessibility_manager.h
index ad073bf3d4ed349b44262e81eada1d888702b215..d875e8aedba4107f7fa05afd07967be3921937db 100644
--- a/content/browser/accessibility/browser_accessibility_manager.h
+++ b/content/browser/accessibility/browser_accessibility_manager.h
@@ -15,6 +15,7 @@
#include "base/macros.h"
#include "build/build_config.h"
#include "content/browser/accessibility/ax_tree_id_registry.h"
+#include "content/browser/accessibility/browser_accessibility_event.h"
#include "content/common/content_export.h"
#include "content/public/browser/ax_event_notification_details.h"
#include "third_party/WebKit/public/web/WebAXEnums.h"
@@ -142,19 +143,22 @@ class CONTENT_EXPORT BrowserAccessibilityManager : public ui::AXTreeDelegate {
static ui::AXTreeUpdate GetEmptyDocument();
virtual void NotifyAccessibilityEvent(
- ui::AXEvent event_type, BrowserAccessibility* node) { }
+ BrowserAccessibilityEvent::Source source,
+ ui::AXEvent event_type,
+ BrowserAccessibility* node);
// Checks whether focus has changed since the last time it was checked,
// taking into account whether the window has focus and which frame within
// the frame tree has focus. If focus has changed, calls FireFocusEvent.
- void FireFocusEventsIfNeeded();
+ void FireFocusEventsIfNeeded(BrowserAccessibilityEvent::Source source);
// Return whether or not we are currently able to fire events.
virtual bool CanFireEvents();
// Fire a focus event. Virtual so that some platforms can customize it,
// like firing a focus event on the root first, on Windows.
- virtual void FireFocusEvent(BrowserAccessibility* node);
+ virtual void FireFocusEvent(BrowserAccessibilityEvent::Source source,
+ BrowserAccessibility* node);
// Return a pointer to the root of the tree, does not make a new reference.
BrowserAccessibility* GetRoot();
@@ -186,10 +190,6 @@ class CONTENT_EXPORT BrowserAccessibilityManager : public ui::AXTreeDelegate {
void NavigationSucceeded();
void NavigationFailed();
- // Called to notify the accessibility manager that a mouse down event
- // occurred in the tab.
- void GotMouseDown();
-
// Send a message to the renderer to set focus to this node.
void SetFocus(const BrowserAccessibility& node);

Powered by Google App Engine
This is Rietveld 408576698