Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: content/browser/accessibility/browser_accessibility_android.cc

Issue 1925473002: Add verbose logging for native accessibility events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@load_complete
Patch Set: address all feedback Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/accessibility/browser_accessibility_android.cc
diff --git a/content/browser/accessibility/browser_accessibility_android.cc b/content/browser/accessibility/browser_accessibility_android.cc
index 55982e9c450858f2d2805eee36cf0d58f9a8ce86..dd96eaa9bd0392460c324ef1eb6411f895ce537b 100644
--- a/content/browser/accessibility/browser_accessibility_android.cc
+++ b/content/browser/accessibility/browser_accessibility_android.cc
@@ -65,7 +65,10 @@ bool BrowserAccessibilityAndroid::IsNative() const {
}
void BrowserAccessibilityAndroid::OnLocationChanged() {
- manager()->NotifyAccessibilityEvent(ui::AX_EVENT_LOCATION_CHANGED, this);
+ manager()->NotifyAccessibilityEvent(
+ BrowserAccessibilityEvent::FromTreeChange,
+ ui::AX_EVENT_LOCATION_CHANGED,
+ this);
}
base::string16 BrowserAccessibilityAndroid::GetValue() const {
@@ -1373,8 +1376,12 @@ void BrowserAccessibilityAndroid::OnDataChanged() {
}
}
- if (GetRole() == ui::AX_ROLE_ALERT && first_time_)
- manager()->NotifyAccessibilityEvent(ui::AX_EVENT_ALERT, this);
+ if (GetRole() == ui::AX_ROLE_ALERT && first_time_) {
+ manager()->NotifyAccessibilityEvent(
+ BrowserAccessibilityEvent::FromTreeChange,
+ ui::AX_EVENT_ALERT,
+ this);
+ }
base::string16 live;
if (GetString16Attribute(
@@ -1394,8 +1401,10 @@ void BrowserAccessibilityAndroid::NotifyLiveRegionUpdate(
base::string16 text = GetText();
if (cached_text_ != text) {
if (!text.empty()) {
- manager()->NotifyAccessibilityEvent(ui::AX_EVENT_SHOW,
- this);
+ manager()->NotifyAccessibilityEvent(
+ BrowserAccessibilityEvent::FromTreeChange,
+ ui::AX_EVENT_SHOW,
+ this);
}
cached_text_ = text;
}
« no previous file with comments | « content/browser/accessibility/browser_accessibility.cc ('k') | content/browser/accessibility/browser_accessibility_event.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698