device/usb/mojo/device_impl.h - Issue 1925463002: Mojo: Make device/ to not rely on connecton error notification on message loop destruction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/usb/mojo/device_impl.h

Issue 1925463002: Mojo: Make device/ to not rely on connecton error notification on message loop destruction. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: device/usb/mojo/device_impl.h

diff --git a/device/usb/mojo/device_impl.h b/device/usb/mojo/device_impl.h

index a0a4cfc551bc0f4f034c3f778a4cdd81a358de76..73ca880a7a47414539e1344791dd6ba5e4f96f74 100644

--- a/device/usb/mojo/device_impl.h

+++ b/device/usb/mojo/device_impl.h

@@ -16,9 +16,9 @@

#include "device/usb/public/interfaces/device.mojom.h"

#include "device/usb/usb_device.h"

#include "device/usb/usb_device_handle.h"

-#include "mojo/public/cpp/bindings/binding.h"

#include "mojo/public/cpp/bindings/callback.h"

#include "mojo/public/cpp/bindings/interface_request.h"

+#include "mojo/public/cpp/bindings/strong_binding.h"

namespace net {

class IOBuffer;

@@ -109,7 +109,7 @@ class DeviceImpl : public Device, public device::UsbDevice::Observer {

// has been closed.

scoped_refptr<UsbDeviceHandle> device_handle_;

- mojo::Binding<Device> binding_;

+ mojo::StrongBinding<Device> binding_;

base::WeakPtrFactory<DeviceImpl> weak_factory_;

DISALLOW_COPY_AND_ASSIGN(DeviceImpl);

« no previous file with comments | « device/serial/data_source_sender.cc ('k') | device/usb/mojo/device_impl.cc » ('j') | no next file with comments »