Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1925453005: Remove most of the loading delay for warning icon. (Closed)

Created:
4 years, 7 months ago by jdufault
Modified:
4 years, 7 months ago
CC:
chromium-reviews, dzhioev+watch_chromium.org, achuith+watch_chromium.org, anthonyvd, Moe
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkgr
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove most of the loading delay for warning icon. This does not appear to cause any performance regressions when loading the lock screen. BUG=605893 Committed: https://crrev.com/637d3009b75b4837c9a151e84615f57b984a8fa2 Cr-Commit-Position: refs/heads/master@{#393111}

Patch Set 1 #

Patch Set 2 : Fix tests #

Total comments: 1

Patch Set 3 : Remove let #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -15 lines) Patch
M ui/login/account_picker/user_pod_template.js View 1 2 1 chunk +17 lines, -15 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
jdufault
PTAL. There was a bug complaining that the warning icon takes too long to appear. ...
4 years, 7 months ago (2016-05-05 17:11:25 UTC) #3
achuithb
LGTM. Please wait for Alex https://codereview.chromium.org/1925453005/diff/20001/ui/login/account_picker/user_pod_template.js File ui/login/account_picker/user_pod_template.js (right): https://codereview.chromium.org/1925453005/diff/20001/ui/login/account_picker/user_pod_template.js#newcode21 ui/login/account_picker/user_pod_template.js:21: let link = document.createElement('link'); ...
4 years, 7 months ago (2016-05-05 20:18:31 UTC) #4
Alexander Alekseev
lgtm
4 years, 7 months ago (2016-05-05 21:46:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1925453005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1925453005/20001
4 years, 7 months ago (2016-05-11 22:37:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1925453005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1925453005/40001
4 years, 7 months ago (2016-05-11 22:38:41 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-11 23:59:36 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-12 00:01:12 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/637d3009b75b4837c9a151e84615f57b984a8fa2
Cr-Commit-Position: refs/heads/master@{#393111}

Powered by Google App Engine
This is Rietveld 408576698