Move CPDF_Document code into cpdf_document.cpp.

Move CPDF_Document code into cpdf_document.cpp.

Committed: https://pdfium.googlesource.com/pdfium/+/931bf37379db7274d0e42f68cf358749cb05ba89

[Lei Zhang, 2016-04-26 23:06:36]

thestig@chromium.org changed reviewers:
+ dsinclair@chromium.org

[Lei Zhang, 2016-04-26 23:06:37]

https://codereview.chromium.org/1925453002/diff/20001/core/fpdfapi/fpdf_parse...
File core/fpdfapi/fpdf_parser/cpdf_document.cpp (right):

https://codereview.chromium.org/1925453002/diff/20001/core/fpdfapi/fpdf_parse...
core/fpdfapi/fpdf_parser/cpdf_document.cpp:1323: pArray->AddName(name.IsEmpty()
? ".notdef" : name);
Yes, this is on lines 906 and 1121 as well. This file needs more clean up
passes.

[dsinclair, 2016-04-27 02:59:41]

lgtm w/ nits.

https://codereview.chromium.org/1925453002/diff/60001/core/fpdfapi/fpdf_parse...
File core/fpdfapi/fpdf_parser/cpdf_document.cpp (right):

https://codereview.chromium.org/1925453002/diff/60001/core/fpdfapi/fpdf_parse...
core/fpdfapi/fpdf_parser/cpdf_document.cpp:219: int uCharset;
Can this int be a uint8_t?

https://codereview.chromium.org/1925453002/diff/60001/core/fpdfapi/fpdf_parse...
core/fpdfapi/fpdf_parser/cpdf_document.cpp:549: #define FX_MAX_PAGE_LEVEL 1024
nit: move this to the top of the file?

https://codereview.chromium.org/1925453002/diff/60001/core/fpdfapi/fpdf_parse...
core/fpdfapi/fpdf_parser/cpdf_document.cpp:631: }
nit: no {}'s

https://codereview.chromium.org/1925453002/diff/60001/core/fpdfapi/fpdf_parse...
core/fpdfapi/fpdf_parser/cpdf_document.cpp:665: }
nit: no {}'s

https://codereview.chromium.org/1925453002/diff/60001/core/fpdfapi/fpdf_parse...
core/fpdfapi/fpdf_parser/cpdf_document.cpp:672: }
ditto

https://codereview.chromium.org/1925453002/diff/60001/core/fpdfapi/fpdf_parse...
File core/fpdfapi/fpdf_parser/include/cpdf_document.h (right):

https://codereview.chromium.org/1925453002/diff/60001/core/fpdfapi/fpdf_parse...
core/fpdfapi/fpdf_parser/include/cpdf_document.h:131: // TODO(thestig): Figure
out why tis cannot be a std::unique_ptr.
nit: s/tis/this/

[Lei Zhang, 2016-04-27 05:22:02]

https://codereview.chromium.org/1925453002/diff/60001/core/fpdfapi/fpdf_parse...
File core/fpdfapi/fpdf_parser/cpdf_document.cpp (right):

https://codereview.chromium.org/1925453002/diff/60001/core/fpdfapi/fpdf_parse...
core/fpdfapi/fpdf_parser/cpdf_document.cpp:219: int uCharset;
On 2016/04/27 02:59:41, dsinclair wrote:
> Can this int be a uint8_t?

Yes, and in more places in related code.

https://codereview.chromium.org/1925453002/diff/60001/core/fpdfapi/fpdf_parse...
core/fpdfapi/fpdf_parser/cpdf_document.cpp:549: #define FX_MAX_PAGE_LEVEL 1024
On 2016/04/27 02:59:41, dsinclair wrote:
> nit: move this to the top of the file?

Done.

https://codereview.chromium.org/1925453002/diff/60001/core/fpdfapi/fpdf_parse...
core/fpdfapi/fpdf_parser/cpdf_document.cpp:631: }
On 2016/04/27 02:59:41, dsinclair wrote:
> nit: no {}'s

Done.

https://codereview.chromium.org/1925453002/diff/60001/core/fpdfapi/fpdf_parse...
core/fpdfapi/fpdf_parser/cpdf_document.cpp:665: }
On 2016/04/27 02:59:41, dsinclair wrote:
> nit: no {}'s

Done.

https://codereview.chromium.org/1925453002/diff/60001/core/fpdfapi/fpdf_parse...
core/fpdfapi/fpdf_parser/cpdf_document.cpp:672: }
On 2016/04/27 02:59:41, dsinclair wrote:
> ditto

Done.

https://codereview.chromium.org/1925453002/diff/60001/core/fpdfapi/fpdf_parse...
File core/fpdfapi/fpdf_parser/include/cpdf_document.h (right):

https://codereview.chromium.org/1925453002/diff/60001/core/fpdfapi/fpdf_parse...
core/fpdfapi/fpdf_parser/include/cpdf_document.h:131: // TODO(thestig): Figure
out why tis cannot be a std::unique_ptr.
On 2016/04/27 02:59:41, dsinclair wrote:
> nit: s/tis/this/

Done.

[Lei Zhang, 2016-04-27 05:22:07]

The CQ bit was checked by thestig@chromium.org

[Lei Zhang, 2016-04-27 05:22:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
dsinclair@chromium.org
Link to the patchset: https://codereview.chromium.org/1925453002/#ps80001
(title: "nits")

[commit-bot: I haz the power, 2016-04-27 05:22:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1925453002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1925453002/80001

[commit-bot: I haz the power, 2016-04-27 05:24:33]

Description was changed from

==========
Move CPDF_Document code into cpdf_document.cpp.
==========

to

==========
Move CPDF_Document code into cpdf_document.cpp.

Committed:
https://pdfium.googlesource.com/pdfium/+/931bf37379db7274d0e42f68cf358749cb05...
==========

[commit-bot: I haz the power, 2016-04-27 05:24:34]

Committed patchset #5 (id:80001) as
https://pdfium.googlesource.com/pdfium/+/931bf37379db7274d0e42f68cf358749cb05...