Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(995)

Side by Side Diff: content/shell/BUILD.gn

Issue 1925383003: [Mac/GN] Port tweak_info_plist.py and run it on //content targets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove extra checks Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/mac/tweak_info_plist.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/features.gni") 5 import("//build/config/features.gni")
6 import("//build/config/sanitizers/sanitizers.gni") 6 import("//build/config/sanitizers/sanitizers.gni")
7 import("//build/config/ui.gni") 7 import("//build/config/ui.gni")
8 import("//build/config/win/console_app.gni") 8 import("//build/config/win/console_app.gni")
9 import("//build/config/win/manifest.gni") 9 import("//build/config/win/manifest.gni")
10 import("//media/media_options.gni") 10 import("//media/media_options.gni")
11 import("//mojo/public/tools/bindings/mojom.gni") 11 import("//mojo/public/tools/bindings/mojom.gni")
12 import("//tools/grit/repack.gni") 12 import("//tools/grit/repack.gni")
13 import("//tools/grit/grit_rule.gni") 13 import("//tools/grit/grit_rule.gni")
14 if (is_android) { 14 if (is_android) {
15 import("//build/config/android/config.gni") 15 import("//build/config/android/config.gni")
16 } else if (is_mac) { 16 } else if (is_mac) {
17 import("//build/config/mac/rules.gni") 17 import("//build/config/mac/rules.gni")
18 import("//build_overrides/v8.gni") 18 import("//build_overrides/v8.gni")
19 import("//build/mac/tweak_info_plist.gni")
19 } 20 }
20 21
21 declare_args() { 22 declare_args() {
22 content_shell_product_name = "Content Shell" 23 content_shell_product_name = "Content Shell"
23 content_shell_version = "99.77.34.5" 24 content_shell_version = "99.77.34.5"
24 } 25 }
25 26
26 config("content_shell_lib_warnings") { 27 config("content_shell_lib_warnings") {
27 if (is_clang) { 28 if (is_clang) {
28 # TODO(thakis): Remove this once http://crbug.com/383820 is figured out 29 # TODO(thakis): Remove this once http://crbug.com/383820 is figured out
(...skipping 394 matching lines...) Expand 10 before | Expand all | Expand 10 after
423 } 424 }
424 425
425 if (is_android) { 426 if (is_android) {
426 group("content_shell") { 427 group("content_shell") {
427 testonly = true 428 testonly = true
428 deps = [ 429 deps = [
429 "//content/shell/android:content_shell_apk", 430 "//content/shell/android:content_shell_apk",
430 ] 431 ]
431 } 432 }
432 } else if (is_mac) { 433 } else if (is_mac) {
434 tweak_info_plist("content_shell_plist") {
435 testonly = true
436 info_plist = "app/app-Info.plist"
437 args = [
438 "--scm=1",
439 "--version",
440 content_shell_version,
441 ]
442 }
433 mac_app_bundle("content_shell") { 443 mac_app_bundle("content_shell") {
434 testonly = true 444 testonly = true
435 output_name = content_shell_product_name 445 output_name = content_shell_product_name
436 sources = [ 446 sources = [
437 "app/shell_main.cc", 447 "app/shell_main.cc",
438 ] 448 ]
439 deps = [ 449 deps = [
440 ":content_shell_framework_bundle_data", 450 ":content_shell_framework_bundle_data",
441 ":content_shell_resources_bundle_data", 451 ":content_shell_resources_bundle_data",
442 452
443 # TODO(rsesek): Remove this after GYP is gone, since it only needs to 453 # TODO(rsesek): Remove this after GYP is gone, since it only needs to
444 # be here per the comment in blink_test_platform_support_mac.mm about 454 # be here per the comment in blink_test_platform_support_mac.mm about
445 # the bundle structure. 455 # the bundle structure.
446 "//components/test_runner:resources", 456 "//components/test_runner:resources",
447 ] 457 ]
448 info_plist = "app/app-Info.plist" 458 info_plist_target = ":content_shell_plist"
449 } 459 }
450 } else { 460 } else {
451 # TODO(brettw) when GYP is no longer necessary, delete 461 # TODO(brettw) when GYP is no longer necessary, delete
452 # content/shell/app/shell.exe.manifest. This file is not used in GN. 462 # content/shell/app/shell.exe.manifest. This file is not used in GN.
453 executable("content_shell") { 463 executable("content_shell") {
454 testonly = true 464 testonly = true
455 465
456 # TODO(GYP) mac resource bundle stuff for this target. 466 # TODO(GYP) mac resource bundle stuff for this target.
457 sources = [ 467 sources = [
458 "app/shell_main.cc", 468 "app/shell_main.cc",
(...skipping 106 matching lines...) Expand 10 before | Expand all | Expand 10 after
565 public_deps = [ 575 public_deps = [
566 "//ppapi:blink_deprecated_test_plugin", 576 "//ppapi:blink_deprecated_test_plugin",
567 "//ppapi:blink_test_plugin", 577 "//ppapi:blink_test_plugin",
568 ] 578 ]
569 } 579 }
570 } 580 }
571 581
572 content_shell_framework_name = "$content_shell_product_name Framework" 582 content_shell_framework_name = "$content_shell_product_name Framework"
573 content_shell_helper_name = "$content_shell_product_name Helper" 583 content_shell_helper_name = "$content_shell_product_name Helper"
574 584
585 tweak_info_plist("content_shell_framework_plist") {
586 testonly = true
587 info_plist = "app/framework-Info.plist"
588 args = [
589 "--breakpad=1",
590 "--keystone=0",
591 "--scm=1",
592 "--version",
593 content_shell_version,
594 "--branding",
595 content_shell_product_name,
596 ]
597 }
598
575 mac_framework_bundle("content_shell_framework") { 599 mac_framework_bundle("content_shell_framework") {
576 testonly = true 600 testonly = true
577 601
578 output_name = content_shell_framework_name 602 output_name = content_shell_framework_name
579 603
580 sources = [ 604 sources = [
581 "app/shell_content_main.cc", 605 "app/shell_content_main.cc",
582 "app/shell_content_main.h", 606 "app/shell_content_main.h",
583 ] 607 ]
584 608
(...skipping 10 matching lines...) Expand all
595 619
596 if (enable_plugins) { 620 if (enable_plugins) {
597 deps += [ ":content_shell_framework_plugins" ] 621 deps += [ ":content_shell_framework_plugins" ]
598 } 622 }
599 623
600 ldflags = [ 624 ldflags = [
601 "-install_name", 625 "-install_name",
602 "@executable_path/../Frameworks/$output_name.framework/$output_name", 626 "@executable_path/../Frameworks/$output_name.framework/$output_name",
603 ] 627 ]
604 628
605 info_plist = "app/framework-Info.plist" 629 info_plist_target = ":content_shell_framework_plist"
630 }
631
632 tweak_info_plist("content_shell_helper_plist") {
633 testonly = true
634 info_plist = "app/helper-Info.plist"
635 args = [
636 "--breakpad=0",
637 "--keystone=0",
638 "--scm=0",
639 "--version",
640 content_shell_version,
641 ]
606 } 642 }
607 643
608 mac_app_bundle("content_shell_helper_app") { 644 mac_app_bundle("content_shell_helper_app") {
609 testonly = true 645 testonly = true
610 output_name = content_shell_helper_name 646 output_name = content_shell_helper_name
611 sources = [ 647 sources = [
612 "app/shell_main.cc", 648 "app/shell_main.cc",
613 ] 649 ]
614 deps = [ 650 deps = [
615 ":content_shell_framework+link", 651 ":content_shell_framework+link",
616 ] 652 ]
617 info_plist = "app/helper-Info.plist" 653 info_plist_target = ":content_shell_helper_plist"
618 } 654 }
619 655
620 # The install_name_tool can only operate in-place, rather than producing a 656 # The install_name_tool can only operate in-place, rather than producing a
621 # unique output. Use the xcrun wrapper script to write a fake stamp output 657 # unique output. Use the xcrun wrapper script to write a fake stamp output
622 # file. After :content_shell_helper_app has been built and bundled, this 658 # file. After :content_shell_helper_app has been built and bundled, this
623 # will run, modifying the executable in the bundle and writing out the 659 # will run, modifying the executable in the bundle and writing out the
624 # --stamp specified. This will change the mtime on the executable, but 660 # --stamp specified. This will change the mtime on the executable, but
625 # because the stamp will also be updated, the 661 # because the stamp will also be updated, the
626 # :content_shell_framework_bundle_data will re-copy the output. This only 662 # :content_shell_framework_bundle_data will re-copy the output. This only
627 # works because nothing else depends on the output of 663 # works because nothing else depends on the output of
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
681 "{{bundle_resources_dir}}/{{source_file_part}}", 717 "{{bundle_resources_dir}}/{{source_file_part}}",
682 ] 718 ]
683 } 719 }
684 } 720 }
685 721
686 mojom("mojo_bindings") { 722 mojom("mojo_bindings") {
687 sources = [ 723 sources = [
688 "common/layout_test/layout_test_bluetooth_fake_adapter_setter.mojom", 724 "common/layout_test/layout_test_bluetooth_fake_adapter_setter.mojom",
689 ] 725 ]
690 } 726 }
OLDNEW
« no previous file with comments | « build/mac/tweak_info_plist.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698