Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Side by Side Diff: content/shell/BUILD.gn

Issue 1925383003: [Mac/GN] Port tweak_info_plist.py and run it on //content targets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« build/config/mac/rules.gni ('K') | « build/mac/tweak_info_plist.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/features.gni") 5 import("//build/config/features.gni")
6 import("//build/config/sanitizers/sanitizers.gni") 6 import("//build/config/sanitizers/sanitizers.gni")
7 import("//build/config/ui.gni") 7 import("//build/config/ui.gni")
8 import("//build/config/win/console_app.gni") 8 import("//build/config/win/console_app.gni")
9 import("//build/config/win/manifest.gni") 9 import("//build/config/win/manifest.gni")
10 import("//media/media_options.gni") 10 import("//media/media_options.gni")
11 import("//mojo/public/tools/bindings/mojom.gni") 11 import("//mojo/public/tools/bindings/mojom.gni")
12 import("//tools/grit/repack.gni") 12 import("//tools/grit/repack.gni")
13 import("//tools/grit/grit_rule.gni") 13 import("//tools/grit/grit_rule.gni")
14 if (is_android) { 14 if (is_android) {
15 import("//build/config/android/config.gni") 15 import("//build/config/android/config.gni")
16 } else if (is_mac) { 16 } else if (is_mac) {
17 import("//build/config/mac/rules.gni") 17 import("//build/config/mac/rules.gni")
18 import("//build_overrides/v8.gni") 18 import("//build_overrides/v8.gni")
19 import("//build/mac/tweak_info_plist.gni")
19 } 20 }
20 21
21 declare_args() { 22 declare_args() {
22 content_shell_product_name = "Content Shell" 23 content_shell_product_name = "Content Shell"
23 content_shell_version = "99.77.34.5" 24 content_shell_version = "99.77.34.5"
24 } 25 }
25 26
26 config("content_shell_lib_warnings") { 27 config("content_shell_lib_warnings") {
27 if (is_clang) { 28 if (is_clang) {
28 # TODO(thakis): Remove this once http://crbug.com/383820 is figured out 29 # TODO(thakis): Remove this once http://crbug.com/383820 is figured out
(...skipping 395 matching lines...) Expand 10 before | Expand all | Expand 10 after
424 } 425 }
425 426
426 if (is_android) { 427 if (is_android) {
427 group("content_shell") { 428 group("content_shell") {
428 testonly = true 429 testonly = true
429 deps = [ 430 deps = [
430 "//content/shell/android:content_shell_apk", 431 "//content/shell/android:content_shell_apk",
431 ] 432 ]
432 } 433 }
433 } else if (is_mac) { 434 } else if (is_mac) {
435 tweak_info_plist("content_shell_plist") {
436 testonly = true
437 info_plist = "app/app-Info.plist"
438 args = [
439 "--scm=1",
440 "--version",
441 content_shell_version,
442 ]
443 }
434 mac_app_bundle("content_shell") { 444 mac_app_bundle("content_shell") {
435 testonly = true 445 testonly = true
436 output_name = content_shell_product_name 446 output_name = content_shell_product_name
437 sources = [ 447 sources = [
438 "app/shell_main.cc", 448 "app/shell_main.cc",
439 ] 449 ]
440 deps = [ 450 deps = [
441 ":content_shell_framework_bundle_data", 451 ":content_shell_framework_bundle_data",
442 ":content_shell_resources_bundle_data", 452 ":content_shell_resources_bundle_data",
443 453
444 # TODO(rsesek): Remove this after GYP is gone, since it only needs to 454 # TODO(rsesek): Remove this after GYP is gone, since it only needs to
445 # be here per the comment in blink_test_platform_support_mac.mm about 455 # be here per the comment in blink_test_platform_support_mac.mm about
446 # the bundle structure. 456 # the bundle structure.
447 "//components/test_runner:resources", 457 "//components/test_runner:resources",
448 ] 458 ]
449 info_plist = "app/app-Info.plist" 459 info_plist_target = ":content_shell_plist"
450 } 460 }
451 } else { 461 } else {
452 # TODO(brettw) when GYP is no longer necessary, delete 462 # TODO(brettw) when GYP is no longer necessary, delete
453 # content/shell/app/shell.exe.manifest. This file is not used in GN. 463 # content/shell/app/shell.exe.manifest. This file is not used in GN.
454 executable("content_shell") { 464 executable("content_shell") {
455 testonly = true 465 testonly = true
456 466
457 # TODO(GYP) mac resource bundle stuff for this target. 467 # TODO(GYP) mac resource bundle stuff for this target.
458 # TODO(GYP) Windows content shell settings: 468 # TODO(GYP) Windows content shell settings:
459 # - RC file. 469 # - RC file.
(...skipping 100 matching lines...) Expand 10 before | Expand all | Expand 10 after
560 public_deps = [ 570 public_deps = [
561 "//ppapi:blink_deprecated_test_plugin", 571 "//ppapi:blink_deprecated_test_plugin",
562 "//ppapi:blink_test_plugin", 572 "//ppapi:blink_test_plugin",
563 ] 573 ]
564 } 574 }
565 } 575 }
566 576
567 content_shell_framework_name = "$content_shell_product_name Framework" 577 content_shell_framework_name = "$content_shell_product_name Framework"
568 content_shell_helper_name = "$content_shell_product_name Helper" 578 content_shell_helper_name = "$content_shell_product_name Helper"
569 579
580 tweak_info_plist("content_shell_framework_plist") {
581 testonly = true
582 info_plist = "app/framework-Info.plist"
583 args = [
584 "--breakpad=1",
585 "--keystone=0",
586 "--scm=1",
587 "--version",
588 content_shell_version,
589 "--branding",
590 content_shell_product_name,
591 ]
592 }
593
570 mac_framework_bundle("content_shell_framework") { 594 mac_framework_bundle("content_shell_framework") {
571 testonly = true 595 testonly = true
572 596
573 output_name = content_shell_framework_name 597 output_name = content_shell_framework_name
574 598
575 sources = [ 599 sources = [
576 "app/shell_content_main.cc", 600 "app/shell_content_main.cc",
577 "app/shell_content_main.h", 601 "app/shell_content_main.h",
578 ] 602 ]
579 603
(...skipping 10 matching lines...) Expand all
590 614
591 if (enable_plugins) { 615 if (enable_plugins) {
592 deps += [ ":content_shell_framework_plugins" ] 616 deps += [ ":content_shell_framework_plugins" ]
593 } 617 }
594 618
595 ldflags = [ 619 ldflags = [
596 "-install_name", 620 "-install_name",
597 "@executable_path/../Frameworks/$output_name.framework/$output_name", 621 "@executable_path/../Frameworks/$output_name.framework/$output_name",
598 ] 622 ]
599 623
600 info_plist = "app/framework-Info.plist" 624 info_plist_target = ":content_shell_framework_plist"
625 }
626
627 tweak_info_plist("content_shell_helper_plist") {
628 testonly = true
629 info_plist = "app/helper-Info.plist"
630 args = [
631 "--breakpad=0",
632 "--keystone=0",
633 "--scm=0",
634 "--version",
635 content_shell_version,
636 ]
601 } 637 }
602 638
603 mac_app_bundle("content_shell_helper_app") { 639 mac_app_bundle("content_shell_helper_app") {
604 testonly = true 640 testonly = true
605 output_name = content_shell_helper_name 641 output_name = content_shell_helper_name
606 sources = [ 642 sources = [
607 "app/shell_main.cc", 643 "app/shell_main.cc",
608 ] 644 ]
609 deps = [ 645 deps = [
610 ":content_shell_framework+link", 646 ":content_shell_framework+link",
611 ] 647 ]
612 info_plist = "app/helper-Info.plist" 648 info_plist_target = ":content_shell_helper_plist"
613 } 649 }
614 650
615 # The install_name_tool can only operate in-place, rather than producing a 651 # The install_name_tool can only operate in-place, rather than producing a
616 # unique output. Use the xcrun wrapper script to write a fake stamp output 652 # unique output. Use the xcrun wrapper script to write a fake stamp output
617 # file. After :content_shell_helper_app has been built and bundled, this 653 # file. After :content_shell_helper_app has been built and bundled, this
618 # will run, modifying the executable in the bundle and writing out the 654 # will run, modifying the executable in the bundle and writing out the
619 # --stamp specified. This will change the mtime on the executable, but 655 # --stamp specified. This will change the mtime on the executable, but
620 # because the stamp will also be updated, the 656 # because the stamp will also be updated, the
621 # :content_shell_framework_bundle_data will re-copy the output. This only 657 # :content_shell_framework_bundle_data will re-copy the output. This only
622 # works because nothing else depends on the output of 658 # works because nothing else depends on the output of
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
676 "{{bundle_resources_dir}}/{{source_file_part}}", 712 "{{bundle_resources_dir}}/{{source_file_part}}",
677 ] 713 ]
678 } 714 }
679 } 715 }
680 716
681 mojom("mojo_bindings") { 717 mojom("mojo_bindings") {
682 sources = [ 718 sources = [
683 "common/layout_test/layout_test_bluetooth_fake_adapter_setter.mojom", 719 "common/layout_test/layout_test_bluetooth_fake_adapter_setter.mojom",
684 ] 720 ]
685 } 721 }
OLDNEW
« build/config/mac/rules.gni ('K') | « build/mac/tweak_info_plist.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698