xfa/fxgraphics/cagg_graphics.cpp - Issue 1925363002: Do not check pointers before deleting them.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fxgraphics/cagg_graphics.cpp

Issue 1925363002: Do not check pointers before deleting them. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fxgraphics/cagg_graphics.cpp

diff --git a/xfa/fxgraphics/cagg_graphics.cpp b/xfa/fxgraphics/cagg_graphics.cpp

index 4c9e41fea3c6c7eec3eb66b5d4119f3eb9a6c0df..a4211810c40371edf0ce6079426e21f75944b9de 100644

--- a/xfa/fxgraphics/cagg_graphics.cpp

+++ b/xfa/fxgraphics/cagg_graphics.cpp

@@ -26,7 +26,5 @@ FX_ERR CAGG_Graphics::Create(CFX_Graphics* owner,

}

CAGG_Graphics::~CAGG_Graphics() {

- if (m_owner->m_renderDevice)

- delete (CFX_FxgeDevice*)m_owner->m_renderDevice;

- m_owner = nullptr;

+ delete m_owner->m_renderDevice;

}