Do not check pointers before deleting them.

xfa/fxbarcode/pdf417/BC_PDF417.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 // Original code is licensed as follows:
 /*
  * Copyright 2006 Jeremias Maerki in part, and ZXing Authors in part
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
@@ skipping 383 matching lines @@
 }
 CBC_PDF417::CBC_PDF417(FX_BOOL compact) {
   m_compact = compact;
   m_compaction = AUTO;
   m_minCols = 1;
   m_maxCols = 30;
   m_maxRows = 90;
   m_minRows = 3;
   m_barcodeMatrix = NULL;
 }
+
 CBC_PDF417::~CBC_PDF417() {
-  if (m_barcodeMatrix) {
-    delete m_barcodeMatrix;
-  }
+  delete m_barcodeMatrix;
 }
+
 CBC_BarcodeMatrix* CBC_PDF417::getBarcodeMatrix() {
   return m_barcodeMatrix;
 }
 void CBC_PDF417::generateBarcodeLogic(CFX_WideString msg,
                                       int32_t errorCorrectionLevel,
                                       int32_t& e) {
   int32_t errorCorrectionCodeWords =
       CBC_PDF417ErrorCorrection::getErrorCorrectionCodewordCount(
           errorCorrectionLevel, e);
   BC_EXCEPTION_CHECK_ReturnVoid(e);
@@ skipping 130 matching lines @@
     if (rows > m_maxRows) {
       continue;
     }
     FX_FLOAT newRatio =
         ((17 * cols + 69) * DEFAULT_MODULE_WIDTH) / (rows * HEIGHT);
     if (dimension &&
         fabsf(newRatio - PREFERRED_RATIO) > fabsf(ratio - PREFERRED_RATIO)) {
       continue;
     }
     ratio = newRatio;
-    if (dimension) {
-      delete dimension;
-    }
+    delete dimension;
     dimension = new CFX_Int32Array;
     dimension->Add(cols);
     dimension->Add(rows);
   }
   if (dimension == NULL) {
     int32_t rows = calculateNumberOfRows(sourceCodeWords,
                                          errorCorrectionCodeWords, m_minCols);
     if (rows < m_minRows) {
       dimension = new CFX_Int32Array;
       dimension->Add(m_minCols);
       dimension->Add(m_minRows);
     } else if (rows >= 3 && rows <= 90) {
       dimension = new CFX_Int32Array;
       dimension->Add(m_minCols);
       dimension->Add(rows);
     }
   }
   if (dimension == NULL) {
     e = BCExceptionUnableToFitMessageInColumns;
     return NULL;
   }
   return dimension;
 }