Do not check pointers before deleting them.

xfa/fwl/theme/cfwl_widgettp.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "xfa/fwl/theme/cfwl_widgettp.h"
 
 #include <algorithm>
 
@@ skipping 723 matching lines @@
   CFWL_FontManager::DestroyInstance();
 }
 uint32_t FWL_GetThemeLayout(uint32_t dwThemeID) {
   return 0xffff0000 & dwThemeID;
 }
 uint32_t FWL_GetThemeColor(uint32_t dwThemeID) {
   return 0x0000ffff & dwThemeID;
 }
 
 CFWL_ArrowData* CFWL_ArrowData::m_pInstance = NULL;
+
 CFWL_ArrowData* CFWL_ArrowData::GetInstance() {
-  if (!m_pInstance) {
+  if (!m_pInstance)
     m_pInstance = new CFWL_ArrowData;
-  }
   return m_pInstance;
 }
+
 FX_BOOL CFWL_ArrowData::IsInstance() {
-  return (m_pInstance != NULL);
+  return !!m_pInstance;
 }
+
 void CFWL_ArrowData::DestroyInstance() {
-  if (m_pInstance) {
-    delete m_pInstance;
-    m_pInstance = NULL;
-  }
+  delete m_pInstance;
+  m_pInstance = nullptr;
 }
+
 CFWL_ArrowData::~CFWL_ArrowData() {
-  if (m_pColorData) {
-    delete m_pColorData;
-    m_pColorData = NULL;
-  }
+  delete m_pColorData;
 }
+
 void CFWL_ArrowData::SetColorData(uint32_t dwID) {
   if (!m_pColorData) {
     m_pColorData = new CColorData;
   }
   if (dwID) {
     m_pColorData->clrBorder[0] = ArgbEncode(255, 142, 153, 125);
     m_pColorData->clrBorder[1] = ArgbEncode(255, 157, 171, 119);
     m_pColorData->clrBorder[2] = ArgbEncode(255, 118, 131, 97);
     m_pColorData->clrBorder[3] = ArgbEncode(255, 172, 168, 153);
     m_pColorData->clrStart[0] = ArgbEncode(255, 203, 215, 186);
@@ skipping 20 matching lines @@
     m_pColorData->clrEnd[0] = ArgbEncode(255, 175, 204, 251);
     m_pColorData->clrEnd[1] = ArgbEncode(255, 185, 218, 251);
     m_pColorData->clrEnd[2] = ArgbEncode(255, 210, 222, 235);
     m_pColorData->clrEnd[3] = ArgbEncode(255, 243, 241, 236);
     m_pColorData->clrSign[0] = ArgbEncode(255, 77, 97, 133);
     m_pColorData->clrSign[1] = ArgbEncode(255, 77, 97, 133);
     m_pColorData->clrSign[2] = ArgbEncode(255, 77, 97, 133);
     m_pColorData->clrSign[3] = ArgbEncode(255, 128, 128, 128);
   }
 }