Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Side by Side Diff: xfa/fwl/theme/cfwl_pushbuttontp.cpp

Issue 1925363002: Do not check pointers before deleting them. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master
Patch Set: rebase Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « xfa/fwl/theme/cfwl_formtp.cpp ('k') | xfa/fwl/theme/cfwl_scrollbartp.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "xfa/fwl/theme/cfwl_pushbuttontp.h" 7 #include "xfa/fwl/theme/cfwl_pushbuttontp.h"
8 8
9 #include "xfa/fwl/basewidget/ifwl_pushbutton.h" 9 #include "xfa/fwl/basewidget/ifwl_pushbutton.h"
10 #include "xfa/fwl/core/cfwl_themebackground.h" 10 #include "xfa/fwl/core/cfwl_themebackground.h"
11 #include "xfa/fwl/core/ifwl_themeprovider.h" 11 #include "xfa/fwl/core/ifwl_themeprovider.h"
12 #include "xfa/fwl/core/ifwl_widget.h" 12 #include "xfa/fwl/core/ifwl_widget.h"
13 #include "xfa/fxgraphics/cfx_color.h" 13 #include "xfa/fxgraphics/cfx_color.h"
14 #include "xfa/fxgraphics/cfx_path.h" 14 #include "xfa/fxgraphics/cfx_path.h"
15 15
16 #define PUSHBUTTON_SIZE_Corner 2 16 #define PUSHBUTTON_SIZE_Corner 2
17 17
18 CFWL_PushButtonTP::CFWL_PushButtonTP() { 18 CFWL_PushButtonTP::CFWL_PushButtonTP() : m_pThemeData(new PBThemeData) {
19 m_pThemeData = new PBThemeData;
20 SetThemeData(0); 19 SetThemeData(0);
21 } 20 }
21
22 CFWL_PushButtonTP::~CFWL_PushButtonTP() { 22 CFWL_PushButtonTP::~CFWL_PushButtonTP() {
23 if (m_pThemeData) { 23 delete m_pThemeData;
24 delete m_pThemeData;
25 }
26 } 24 }
25
27 FX_BOOL CFWL_PushButtonTP::IsValidWidget(IFWL_Widget* pWidget) { 26 FX_BOOL CFWL_PushButtonTP::IsValidWidget(IFWL_Widget* pWidget) {
28 return pWidget->GetClassID() == FWL_CLASSHASH_PushButton; 27 return pWidget->GetClassID() == FWL_CLASSHASH_PushButton;
29 } 28 }
30 uint32_t CFWL_PushButtonTP::SetThemeID(IFWL_Widget* pWidget, 29 uint32_t CFWL_PushButtonTP::SetThemeID(IFWL_Widget* pWidget,
31 uint32_t dwThemeID, 30 uint32_t dwThemeID,
32 FX_BOOL bChildren) { 31 FX_BOOL bChildren) {
33 SetThemeData(FWL_GetThemeColor(dwThemeID)); 32 SetThemeData(FWL_GetThemeColor(dwThemeID));
34 return CFWL_WidgetTP::SetThemeID(pWidget, dwThemeID, bChildren); 33 return CFWL_WidgetTP::SetThemeID(pWidget, dwThemeID, bChildren);
35 } 34 }
36 FX_BOOL CFWL_PushButtonTP::DrawBackground(CFWL_ThemeBackground* pParams) { 35 FX_BOOL CFWL_PushButtonTP::DrawBackground(CFWL_ThemeBackground* pParams) {
(...skipping 126 matching lines...) Expand 10 before | Expand all | Expand 10 after
163 if (dwStates & CFWL_PartState_Default) { 162 if (dwStates & CFWL_PartState_Default) {
164 color += 3; 163 color += 3;
165 } else { 164 } else {
166 if (dwStates & CFWL_PartState_Hovered) 165 if (dwStates & CFWL_PartState_Hovered)
167 color += 2; 166 color += 2;
168 if (dwStates & CFWL_PartState_Pressed) 167 if (dwStates & CFWL_PartState_Pressed)
169 color += 1; 168 color += 1;
170 } 169 }
171 return color; 170 return color;
172 } 171 }
OLDNEW
« no previous file with comments | « xfa/fwl/theme/cfwl_formtp.cpp ('k') | xfa/fwl/theme/cfwl_scrollbartp.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698