Do not check pointers before deleting them.

xfa/fwl/core/fwl_widgetmgrimp.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "xfa/fwl/core/fwl_widgetmgrimp.h"
 
 #include "xfa/fwl/core/cfwl_message.h"
 #include "xfa/fwl/core/fwl_appimp.h"
@@ skipping 21 matching lines @@
     : m_dwCapability(0) {
   m_pDelegate = new CFWL_WidgetMgrDelegate(this);
   m_pAdapter = pAdapterNative->GetWidgetMgr(m_pDelegate);
   ASSERT(m_pAdapter);
   CFWL_WidgetMgrItem* pRoot = new CFWL_WidgetMgrItem;
   m_mapWidgetItem.SetAt(NULL, pRoot);
 #if (_FX_OS_ == _FX_WIN32_DESKTOP_) || (_FX_OS_ == _FX_WIN64_)
   m_rtScreen.Reset();
 #endif
 }
+
 CFWL_WidgetMgr::~CFWL_WidgetMgr() {
   FX_POSITION ps = m_mapWidgetItem.GetStartPosition();
   while (ps) {
     void* pWidget;
     CFWL_WidgetMgrItem* pItem;
     m_mapWidgetItem.GetNextAssoc(ps, pWidget, (void*&)pItem);
     delete pItem;
   }
   m_mapWidgetItem.RemoveAll();
-  if (m_pDelegate) {
-    delete m_pDelegate;
-    m_pDelegate = NULL;
-  }
+  delete m_pDelegate;
 }
+
 int32_t CFWL_WidgetMgr::CountWidgets(IFWL_Widget* pParent) {
   CFWL_WidgetMgrItem* pParentItem = GetWidgetMgrItem(pParent);
   return TravelWidgetMgr(pParentItem, NULL, NULL);
 }
 IFWL_Widget* CFWL_WidgetMgr::GetWidget(int32_t nIndex, IFWL_Widget* pParent) {
   CFWL_WidgetMgrItem* pParentItem = GetWidgetMgrItem(pParent);
   IFWL_Widget* pWidget = NULL;
   TravelWidgetMgr(pParentItem, &nIndex, NULL, &pWidget);
   return pWidget;
 }
@@ skipping 407 matching lines @@
       if (bounds.Contains(x1, y1)) {
         x1 -= bounds.left;
         y1 -= bounds.top;
         return GetWidgetAtPoint(child, x1, y1);
       }
     }
     child = GetWidget(child, FWL_WGTRELATION_PriorSibling);
   }
   return parent;
 }
+
 void CFWL_WidgetMgr::NotifySizeChanged(IFWL_Widget* pForm,
                                        FX_FLOAT fx,
                                        FX_FLOAT fy) {
-  if (!FWL_UseOffscreen(pForm)) {
+  if (!FWL_UseOffscreen(pForm))
     return;
-  }
+
   CFWL_WidgetMgrItem* pItem = GetWidgetMgrItem(pForm);
-  if (pItem->pOffscreen) {
-    delete pItem->pOffscreen;
-    pItem->pOffscreen = NULL;
-  }
+  delete pItem->pOffscreen;
+  pItem->pOffscreen = nullptr;
 }
+
 IFWL_Widget* CFWL_WidgetMgr::nextTab(IFWL_Widget* parent,
                                      IFWL_Widget* focus,
                                      FX_BOOL& bFind) {
   IFWL_Widget* child =
       FWL_GetWidgetMgr()->GetWidget(parent, FWL_WGTRELATION_FirstChild);
   while (child) {
     if (focus == child) {
       bFind = TRUE;
     }
     if ((child->GetStyles() & FWL_WGTSTYLE_TabStop) &&
@@ skipping 495 matching lines @@
     CFX_RectF temp(m_pWidgetMgr->m_rtScreen);
     temp.Deflate(50, 50);
     if (!temp.Contains(r)) {
       return FALSE;
     }
     pItem->bOutsideChanged = FALSE;
   }
 #endif
   return pItem->iRedrawCounter == 0;
 }