Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2218)

Unified Diff: appengine/swarming/server/task_result.py

Issue 1925343002: swarming: IsolatedOperation -> OperationStats (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-py@master
Patch Set: swarming: IsolatedOperation -> OperationStats Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/swarming/message_conversion.py ('k') | appengine/swarming/server/task_result_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/swarming/server/task_result.py
diff --git a/appengine/swarming/server/task_result.py b/appengine/swarming/server/task_result.py
index 9a929de53d18c4e0e498bb16d068140378a58a3a..ac1f59b8d1e2a88ba46157ab893ae3be67269e5e 100644
--- a/appengine/swarming/server/task_result.py
+++ b/appengine/swarming/server/task_result.py
@@ -247,7 +247,7 @@ class TaskOutputChunk(ndb.Model):
return self.key.integer_id() - 1
-class IsolatedOperation(ndb.Model):
+class OperationStats(ndb.Model):
"""Statistics for an isolated operation.
M-A Ruel 2016/04/28 21:03:29 s/isolated //
nodir 2016/04/28 21:10:17 Done.
This entity is not stored in the DB. It is only embedded in PerformanceStats.
@@ -290,9 +290,9 @@ class PerformanceStats(ndb.Model):
# isolated_download.duration and isolated_upload.duration.
bot_overhead = ndb.FloatProperty(indexed=False)
# Runtime dependencies download operation before the task.
- isolated_download = ndb.LocalStructuredProperty(IsolatedOperation)
+ isolated_download = ndb.LocalStructuredProperty(OperationStats)
# Results uploading operation after the task.
- isolated_upload = ndb.LocalStructuredProperty(IsolatedOperation)
+ isolated_upload = ndb.LocalStructuredProperty(OperationStats)
@property
def is_valid(self):
@@ -444,8 +444,8 @@ class _TaskResultCommon(ndb.Model):
self._performance_stats_cache = (
(key.get() if key else None) or
PerformanceStats(
- isolated_download=IsolatedOperation(),
- isolated_upload=IsolatedOperation()))
+ isolated_download=OperationStats(),
+ isolated_upload=OperationStats()))
return self._performance_stats_cache
@property
« no previous file with comments | « appengine/swarming/message_conversion.py ('k') | appengine/swarming/server/task_result_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698