Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 1925313002: Tighten up SkSpecialSurface factory functions (Closed)

Created:
4 years, 7 months ago by robertphillips
Modified:
4 years, 7 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Tighten up SkSpecialSurface factory functions This is split out of https://codereview.chromium.org/1930013002/ ((Mostly) Retract GrRenderTarget from SkGpuDevice) GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1925313002 Committed: https://skia.googlesource.com/skia/+/4df1656f0f728ed428c3ab8f7beb19703b27c28e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -67 lines) Patch
M src/core/SkSpecialImage.cpp View 2 chunks +9 lines, -6 lines 0 comments Download
M src/core/SkSpecialSurface.h View 1 chunk +3 lines, -8 lines 0 comments Download
M src/core/SkSpecialSurface.cpp View 3 chunks +18 lines, -20 lines 0 comments Download
M tests/ImageFilterTest.cpp View 1 chunk +3 lines, -6 lines 0 comments Download
M tests/SpecialSurfaceTest.cpp View 1 chunk +3 lines, -27 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
robertphillips
4 years, 7 months ago (2016-04-28 19:33:51 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1925313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1925313002/1
4 years, 7 months ago (2016-04-28 19:36:47 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_64-Debug-Trybot/builds/8265)
4 years, 7 months ago (2016-04-28 19:39:17 UTC) #8
bsalomon
lgtm
4 years, 7 months ago (2016-04-28 21:05:19 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1925313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1925313002/1
4 years, 7 months ago (2016-04-28 21:28:45 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-04-28 21:34:45 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1925313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1925313002/1
4 years, 7 months ago (2016-04-28 22:08:43 UTC) #15
commit-bot: I haz the power
4 years, 7 months ago (2016-04-28 22:09:38 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/4df1656f0f728ed428c3ab8f7beb19703b27c28e

Powered by Google App Engine
This is Rietveld 408576698