Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1925243002: Convert track tests from video-test.js to testharness.js based (Closed)

Created:
4 years, 7 months ago by Srirama
Modified:
4 years, 7 months ago
CC:
blink-reviews, chromium-reviews, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, mlamouri+watch-blink_chromium.org, philipj_slow, nessy, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert track tests from video-test.js to testharness.js based Cleaning up track-default* and track-disabled* tests in media/track to use testharness.js instead of video-test.js. This will enable to upstream these tests to web-platform-tests. BUG=588956 Committed: https://crrev.com/056826d0477d09a94adfaec69a8c2500dc12a9f8 Cr-Commit-Position: refs/heads/master@{#390643}

Patch Set 1 #

Total comments: 4

Patch Set 2 : address comments #

Messages

Total messages: 14 (8 generated)
Srirama
PTAL
4 years, 7 months ago (2016-04-28 18:28:40 UTC) #4
mlamouri (slow - plz ping)
lgtm https://codereview.chromium.org/1925243002/diff/1/third_party/WebKit/LayoutTests/media/track/track-default-attribute.html File third_party/WebKit/LayoutTests/media/track/track-default-attribute.html (right): https://codereview.chromium.org/1925243002/diff/1/third_party/WebKit/LayoutTests/media/track/track-default-attribute.html#newcode18 third_party/WebKit/LayoutTests/media/track/track-default-attribute.html:18: assert_equals(event.target.default, true); assert_true() https://codereview.chromium.org/1925243002/diff/1/third_party/WebKit/LayoutTests/media/track/track-disabled-addcue.html File third_party/WebKit/LayoutTests/media/track/track-disabled-addcue.html (right): https://codereview.chromium.org/1925243002/diff/1/third_party/WebKit/LayoutTests/media/track/track-disabled-addcue.html#newcode21 ...
4 years, 7 months ago (2016-04-29 12:39:12 UTC) #6
Srirama
https://codereview.chromium.org/1925243002/diff/1/third_party/WebKit/LayoutTests/media/track/track-default-attribute.html File third_party/WebKit/LayoutTests/media/track/track-default-attribute.html (right): https://codereview.chromium.org/1925243002/diff/1/third_party/WebKit/LayoutTests/media/track/track-default-attribute.html#newcode18 third_party/WebKit/LayoutTests/media/track/track-default-attribute.html:18: assert_equals(event.target.default, true); On 2016/04/29 12:39:12, Mounir Lamouri wrote: > ...
4 years, 7 months ago (2016-04-29 13:17:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1925243002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1925243002/20001
4 years, 7 months ago (2016-04-29 13:17:28 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-04-29 14:21:40 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:25:42 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/056826d0477d09a94adfaec69a8c2500dc12a9f8
Cr-Commit-Position: refs/heads/master@{#390643}

Powered by Google App Engine
This is Rietveld 408576698