Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 1925233002: S390: [api] Expose FunctionCallbackInfo::NewTarget (Closed)

Created:
4 years, 7 months ago by john.yan
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: [api] Expose FunctionCallbackInfo::NewTarget Port 306c412ce04a7c21a208e33dfce530536453c20d Original commit message: This is needed by Blink to implement the Custom Elements spec. R=adamk@chromium.org, joransiu@ca.ibm.com, bjaideep@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG=v8:4261 LOG=N Committed: https://crrev.com/38e7d1fb1ad3762562357626e3685cf7cfc67ca7 Cr-Commit-Position: refs/heads/master@{#35878}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -19 lines) Patch
M src/s390/builtins-s390.cc View 1 chunk +4 lines, -9 lines 0 comments Download
M src/s390/code-stubs-s390.cc View 4 chunks +11 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
john.yan
PTAL
4 years, 7 months ago (2016-04-28 18:26:52 UTC) #1
JoranSiu
On 2016/04/28 18:26:52, john.yan wrote: > PTAL lgtm
4 years, 7 months ago (2016-04-28 19:15:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1925233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1925233002/1
4 years, 7 months ago (2016-04-28 19:19:58 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-28 19:37:20 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-01 22:02:56 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/38e7d1fb1ad3762562357626e3685cf7cfc67ca7
Cr-Commit-Position: refs/heads/master@{#35878}

Powered by Google App Engine
This is Rietveld 408576698