Add exceptions to features in GpuControlList

Add exceptions to features in GpuControlList

Useful to exclude a feature from "all".

BUG=571899
R=zmo@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/c71ea811c0b35dbec557bd6e74c3b2711ed59ad4
Cr-Commit-Position: refs/heads/master@{#391278}

[Julien Isorce Samsung, 2016-04-28 17:21:44]

Description was changed from

==========
Add exceptions to features in GpuControlList

Useful to exclude a feature from "all".

BUG=571899

R=zmo@chromium.org
==========

to

==========
Add exceptions to features in GpuControlList

Useful to exclude a feature from "all".

BUG=571899

R=zmo@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Julien Isorce Samsung, 2016-04-28 17:31:55]

Hi Zhenyao, this is first draft upon what you suggested in the other CL
https://codereview.chromium.org/1548893004/.

Since the base::JSONParser only accepts Boolean, Integer, Double, String,
Binary, List and Dictionary I am a bit confused how I can do solution "a)" (from
other CL) by only modifying the GpuControlList. So for now I added {} to make it
a valid base::Value within a base::ValueList.

Let me know, thx!

[Zhenyao Mo, 2016-04-29 00:34:17]

Can you add tests to gpu_control_list_entry_unittest.cc?

Also, can you update the gpu_control_list_format.txt?

https://codereview.chromium.org/1925203002/diff/1/gpu/config/gpu_control_list.cc
File gpu/config/gpu_control_list.cc (right):

https://codereview.chromium.org/1925203002/diff/1/gpu/config/gpu_control_list...
gpu/config/gpu_control_list.cc:754:
feature_exception_list.push_back(exception_feature);
else here, malformed feature entry.

https://codereview.chromium.org/1925203002/diff/1/gpu/config/gpu_control_list...
gpu/config/gpu_control_list.cc:756: }
else here, malformed feature entry.

https://codereview.chromium.org/1925203002/diff/1/gpu/config/software_renderi...
File gpu/config/software_rendering_list_json.cc (right):

https://codereview.chromium.org/1925203002/diff/1/gpu/config/software_renderi...
gpu/config/software_rendering_list_json.cc:21: "version": "10.21",
You should update to 11.0 because the json format changed.

[Julien Isorce Samsung, 2016-04-29 15:52:15]

Thx for the review. I added 2 unit tests and addressed other remarks.

https://codereview.chromium.org/1925203002/diff/1/gpu/config/gpu_control_list.cc
File gpu/config/gpu_control_list.cc (right):

https://codereview.chromium.org/1925203002/diff/1/gpu/config/gpu_control_list...
gpu/config/gpu_control_list.cc:754:
feature_exception_list.push_back(exception_feature);
On 2016/04/29 00:34:17, Zhenyao Mo wrote:
> else here, malformed feature entry.

Done.

https://codereview.chromium.org/1925203002/diff/1/gpu/config/gpu_control_list...
gpu/config/gpu_control_list.cc:756: }
On 2016/04/29 00:34:17, Zhenyao Mo wrote:
> else here, malformed feature entry.

Done.

https://codereview.chromium.org/1925203002/diff/1/gpu/config/software_renderi...
File gpu/config/software_rendering_list_json.cc (right):

https://codereview.chromium.org/1925203002/diff/1/gpu/config/software_renderi...
gpu/config/software_rendering_list_json.cc:21: "version": "10.21",
On 2016/04/29 00:34:17, Zhenyao Mo wrote:
> You should update to 11.0 because the json format changed.

Ah ok I understand now when the first number has to be updated. Thx

[Zhenyao Mo, 2016-04-29 17:51:16]

lgtm

[Zhenyao Mo, 2016-04-29 17:51:20]

The CQ bit was checked by zmo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-29 17:51:36]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1925203002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1925203002/20001

[Zhenyao Mo, 2016-04-29 17:52:26]

Do you have the privilege to run CQ dry run?  If not, we should add it to your
account.  Otherwise, it's always nice to trigger that while asking for review.
That gives reviewer more confidence.

[Julien Isorce Samsung, 2016-04-29 19:06:09]

On 2016/04/29 17:52:26, Zhenyao Mo wrote:
> Do you have the privilege to run CQ dry run?  If not, we should add it to your
> account.

I cannot trigger the CQ dry run unless there is at least 1 stamp. How should I
request it ?

> Otherwise, it's always nice to trigger that while asking for review.
> That gives reviewer more confidence.

Acked

[commit-bot: I haz the power, 2016-04-29 19:07:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-29 19:07:26]

Dry run: This issue passed the CQ dry run.

[Julien Isorce Samsung, 2016-05-03 10:13:37]

The CQ bit was checked by j.isorce@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-03 10:13:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1925203002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1925203002/40001

[commit-bot: I haz the power, 2016-05-03 11:25:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-03 11:25:09]

Dry run: This issue passed the CQ dry run.

[Julien Isorce Samsung, 2016-05-03 12:01:48]

The CQ bit was checked by j.isorce@samsung.com

[Julien Isorce Samsung, 2016-05-03 12:01:48]

The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org
Link to the patchset: https://codereview.chromium.org/1925203002/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2016-05-03 12:02:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1925203002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1925203002/40001

[commit-bot: I haz the power, 2016-05-03 12:08:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-03 12:08:54]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Julien Isorce Samsung, 2016-05-03 16:01:28]

The CQ bit was checked by j.isorce@samsung.com

[Julien Isorce Samsung, 2016-05-03 16:01:28]

The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org
Link to the patchset: https://codereview.chromium.org/1925203002/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2016-05-03 16:02:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1925203002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1925203002/60001

[commit-bot: I haz the power, 2016-05-03 17:24:06]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-03 17:25:42]

Description was changed from

==========
Add exceptions to features in GpuControlList

Useful to exclude a feature from "all".

BUG=571899

R=zmo@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Add exceptions to features in GpuControlList

Useful to exclude a feature from "all".

BUG=571899

R=zmo@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/c71ea811c0b35dbec557bd6e74c3b2711ed59ad4
Cr-Commit-Position: refs/heads/master@{#391278}
==========

[commit-bot: I haz the power, 2016-05-03 17:25:44]

Patchset 4 (id:??) landed as
https://crrev.com/c71ea811c0b35dbec557bd6e74c3b2711ed59ad4
Cr-Commit-Position: refs/heads/master@{#391278}