Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(697)

Issue 1925173002: Add a (public) utility method to clean-up code (Closed)

Created:
4 years, 7 months ago by Brian Wilkerson
Modified:
4 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -53 lines) Patch
M pkg/analysis_server/lib/src/services/correction/fix_internal.dart View 1 chunk +1 line, -4 lines 0 comments Download
M pkg/analysis_server/lib/src/services/correction/util.dart View 2 chunks +14 lines, -32 lines 0 comments Download
M pkg/analyzer/lib/dart/ast/ast.dart View 1 chunk +7 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/dart/ast/ast.dart View 2 chunks +14 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 4 chunks +7 lines, -17 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
Not sure whether there will be a performance impact from this, but the code is ...
4 years, 7 months ago (2016-04-28 16:52:19 UTC) #2
scheglov
LGTM
4 years, 7 months ago (2016-04-28 16:58:04 UTC) #3
Brian Wilkerson
4 years, 7 months ago (2016-04-28 17:07:37 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ee8bb2cea93b9b6e87d8c9309e2f22b46331864b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698