Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 1925153003: Undo "Don't include an object header for instructions in the text section." (Closed)

Created:
4 years, 7 months ago by rmacnak
Modified:
4 years, 7 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Undo "Don't include an object header for instructions in the text section." This undoes most of b2f3e8efe1f32bacad99ddbedbc434a6102d8be2. This optimization prevents precompiled code from being disabled and re-enabled, because disabling causes the code to lose its only reference to its own instructions. This was okay for precompilated code that ran without a JIT because it is never disabled, but precompiled code that runs in a JIT will become disabled when corresponding optimized code is compiled and re-abled after a deopt. R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/f7a3e215a50e232fe60b57a6cdea51cc82636b8b

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -62 lines) Patch
M runtime/vm/dart.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/isolate.h View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/isolate.cc View 1 1 chunk +17 lines, -0 lines 0 comments Download
M runtime/vm/object.h View 1 4 chunks +17 lines, -8 lines 0 comments Download
M runtime/vm/object.cc View 1 5 chunks +4 lines, -28 lines 0 comments Download
M runtime/vm/raw_object.h View 1 chunk +3 lines, -5 lines 0 comments Download
M runtime/vm/raw_object_snapshot.cc View 1 3 chunks +16 lines, -11 lines 0 comments Download
M runtime/vm/snapshot.cc View 1 4 chunks +55 lines, -9 lines 0 comments Download
M runtime/vm/stack_frame.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (5 generated)
rmacnak
4 years, 7 months ago (2016-04-28 23:32:27 UTC) #3
Florian Schneider
lgtm
4 years, 7 months ago (2016-05-03 08:39:31 UTC) #6
rmacnak
4 years, 7 months ago (2016-05-03 18:22:34 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
f7a3e215a50e232fe60b57a6cdea51cc82636b8b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698