Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issue 1925143002: Make two compilation flags for Windows Clang build effective (Closed)

Created:
4 years, 7 months ago by Wei Li
Modified:
4 years, 7 months ago
Reviewers:
Lei Zhang, Nico
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Make two compilation flags for Windows Clang build effective These two flags are not properly used. Change to the correct configuration to make them effective. Committed: https://pdfium.googlesource.com/pdfium/+/01a86203141df4a61ae90e289f62c4daf31ee2ba

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -10 lines) Patch
M build_gyp/standalone.gypi View 1 chunk +6 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Wei Li
for reivew, thanks
4 years, 7 months ago (2016-04-28 16:21:34 UTC) #2
Nico
lgtm
4 years, 7 months ago (2016-04-28 19:15:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1925143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1925143002/1
4 years, 7 months ago (2016-04-28 19:32:36 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-04-28 19:44:44 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/01a86203141df4a61ae90e289f62c4daf31e...

Powered by Google App Engine
This is Rietveld 408576698