Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 1925123002: [interpreter] Be explicit when to test BytecodeGraphBuilder. (Closed)

Created:
4 years, 7 months ago by Michael Starzinger
Modified:
4 years, 7 months ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com, Michael Hablich, Stefano Sanfilippo
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Be explicit when to test BytecodeGraphBuilder. This adds a dedicated flag for enabling the BytecodeGraphBuilder. The intention is to be explicit when this variant is being tested and to avoid unnecessary overhead in production code for a configuration that is not yet shipping. R=rmcilroy@chromium.org Committed: https://crrev.com/b06fa13704e3a0694cda77e142003ce166f69988 Cr-Commit-Position: refs/heads/master@{#35892}

Patch Set 1 #

Patch Set 2 : Blacklist tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M src/compiler.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/flag-definitions.h View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/compiler/function-tester.h View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/mjsunit.status View 1 1 chunk +3 lines, -0 lines 0 comments Download
M tools/testrunner/local/testsuite.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Michael Starzinger
4 years, 7 months ago (2016-04-28 15:21:30 UTC) #3
Michael Starzinger
The failing mjsunit/ignition/ignition-statistics-extension test seems to be flushing out an existing bug. Please advise on ...
4 years, 7 months ago (2016-04-28 16:10:52 UTC) #4
rmcilroy
LGTM. Just blacklist mjsunit/ignition/ignition-statistics-extension for now and land this. Thanks! +ssanfilippo for mjsunit/ignition/ignition-statistics-extension failure.
4 years, 7 months ago (2016-04-28 21:33:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1925123002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1925123002/20001
4 years, 7 months ago (2016-04-29 08:38:44 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-04-29 08:40:47 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-01 22:03:21 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b06fa13704e3a0694cda77e142003ce166f69988
Cr-Commit-Position: refs/heads/master@{#35892}

Powered by Google App Engine
This is Rietveld 408576698