third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp - Issue 1925093002: Handle compressed textures allocated via TexStorage2D.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp

Issue 1925093002: Handle compressed textures allocated via TexStorage2D. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed gpu_unittests after last refactor. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp

diff --git a/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp b/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp

index 1cb6bc8050b82f73b8e28287c394a1dbe04d9bf8..d72fab0bdb8231345d0227dd0cbac40a9ec6a3d9 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp

+++ b/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp

@@ -779,7 +779,8 @@ bool WebGL2RenderingContextBase::validateTexStorage(const char* functionName, GL

return false;

}

- if (m_supportedInternalFormatsStorage.find(internalformat) == m_supportedInternalFormatsStorage.end()) {

+ if (m_supportedInternalFormatsStorage.find(internalformat) == m_supportedInternalFormatsStorage.end()

+ && (functionType == TexStorageType2D && !m_compressedTextureFormats.contains(internalformat))) {

synthesizeGLError(GL_INVALID_ENUM, functionName, "invalid internalformat");

return false;

}

« no previous file with comments | « gpu/command_buffer/service/texture_manager_unittest.cc ('k') | no next file » | no next file with comments »