Handle compressed textures allocated via TexStorage2D.

gpu/command_buffer/common/gles2_cmd_utils.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file is here so other GLES2 related files can have a common set of
 // includes where appropriate.
 
 #ifndef GPU_COMMAND_BUFFER_COMMON_GLES2_CMD_UTILS_H_
 #define GPU_COMMAND_BUFFER_COMMON_GLES2_CMD_UTILS_H_
 
@@ skipping 128 matching lines @@
   // Optionally the skipped bytes in the beginning can be returned.
   // Note the returned |size| does NOT include |skip_size|.
   // TODO(zmo): merging ComputeImageDataSize and ComputeImageDataSizeES3.
   static bool ComputeImageDataSizesES3(
       int width, int height, int depth, int format, int type,
       const PixelStoreParams& params,
       uint32_t* size, uint32_t* opt_unpadded_row_size,
       uint32_t* opt_padded_row_size, uint32_t* opt_skip_size,
       uint32_t* opt_padding);
 
+  static bool IsCompressedTextureFormat(int internal_format);

[Zhenyao Mo, 2016/04/28 17:57:12]

You don't have to redefined this function.  We already have
FeatureInfo::validators()->compressed_texture_format, which contains all the
allowed compressed texture formats. You can just use it in the decoder. It's
better if in the future when we add new extensions, we don't have to also update
the duplicated table here.

[Ken Russell (switch to Gerrit), 2016/04/29 13:10:06]

Thanks for pointing this out. It's necessary to call this both from the
GLES2Decoder as well as the TextureManager, but since the TextureManager already
accesses the decoder, it's best to just put it in the decoder. Done.

+
   static size_t RenderbufferBytesPerPixel(int format);
 
   // Return the element's number of bytes.
   // For example, GL_FLOAT_MAT3 returns sizeof(GLfloat).
   static uint32_t GetElementSizeForUniformType(int type);
   // Return the number of elements.
   // For example, GL_FLOAT_MAT3 returns 9.
   static uint32_t GetElementCountForUniformType(int type);
 
   static size_t GetGLTypeSizeForTextures(uint32_t type);
@@ skipping 132 matching lines @@
   bool fail_if_major_perf_caveat;
   bool lose_context_when_out_of_memory;
   ContextType context_type;
 };
 
 }  // namespace gles2
 }  // namespace gpu
 
 #endif  // GPU_COMMAND_BUFFER_COMMON_GLES2_CMD_UTILS_H_