Notify ARC of default network changes

components/arc/net/arc_net_host_impl.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/arc/net/arc_net_host_impl.h"
 
 #include <memory>
 #include <string>
 #include <vector>
 
@@ skipping 11 matching lines @@
 #include "chromeos/network/network_state_handler.h"
 #include "chromeos/network/network_type_pattern.h"
 #include "chromeos/network/network_util.h"
 #include "chromeos/network/onc/onc_utils.h"
 #include "components/arc/arc_bridge_service.h"
 
 namespace {
 
 const int kGetNetworksListLimit = 100;
 
-}  // namespace
-
-namespace arc {
-
 chromeos::NetworkStateHandler* GetStateHandler() {
   return chromeos::NetworkHandler::Get()->network_state_handler();
 }
 
 chromeos::ManagedNetworkConfigurationHandler* GetManagedConfigurationHandler() {
   return chromeos::NetworkHandler::Get()
       ->managed_network_configuration_handler();
 }
 
 chromeos::NetworkConnectionHandler* GetNetworkConnectionHandler() {
   return chromeos::NetworkHandler::Get()->network_connection_handler();
 }
 
 bool IsDeviceOwner() {
   // Check whether the logged-in Chrome OS user is allowed to add or
   // remove WiFi networks.
   return chromeos::LoginState::Get()->GetLoggedInUserType() ==
          chromeos::LoginState::LOGGED_IN_USER_OWNER;
 }
 
+std::string GetStringFromOncDictionary(const base::DictionaryValue* dict,
+                                       const char* key,
+                                       bool required) {
+  std::string tmp;
+  dict->GetString(key, &tmp);
+  if (required && tmp.empty())
+    NOTREACHED();
+  return tmp;
+}
+
+}  // namespace
+
+namespace arc {
+
 ArcNetHostImpl::ArcNetHostImpl(ArcBridgeService* bridge_service)
     : ArcService(bridge_service), binding_(this) {
   arc_bridge_service()->AddObserver(this);
   GetStateHandler()->AddObserver(this, FROM_HERE);
 }
 
 ArcNetHostImpl::~ArcNetHostImpl() {
   DCHECK(thread_checker_.CalledOnValidThread());
   arc_bridge_service()->RemoveObserver(this);
   if (chromeos::NetworkHandler::IsInitialized()) {
@@ skipping 297 matching lines @@
     return;
   }
   if (arc_bridge_service()->net_version() < 1) {
     VLOG(1) << "NetInstance does not support ScanCompleted.";
     return;
   }
 
   arc_bridge_service()->net_instance()->ScanCompleted();
 }
 
+mojom::SecurityType TranslateONCWifiSecurityType(
+    const base::DictionaryValue* dict) {

[dcheng, 2016/05/18 05:32:45]

I've expressed this in past reviews
(https://codereview.chromium.org/1572483002/diff/200001/components/arc/net/arc...),
but I find this pretty unreadable. Can we encapsulate the ONC state into a class
and provide a ToValue() for things that want the base::Value? This avoids the
whole "serialize everything into a base::Value and then parse it back out"
complexity.

[stevenjb, 2016/05/18 15:35:48]

That would be a huge amount of work and, imho, a step backwards.

What would be much more useful would be an ONC .mojom file and a data driven ONC
base::DictionaryValue -> mojo library. Then the translation from ONC -> Arc
could happen in the arc layer instead of in Chrome (which would just pass
complete ONC dictionaries to Arc via mojo).

If I was not completely swamped with other responsibilities I would try to drive
that effort, but unfortunately my focus is elsewhere.

[Kevin Cernekee, 2016/05/18 21:36:58]

Acknowledged.

+  std::string tmp = GetStringFromOncDictionary(dict, onc::wifi::kSecurity,
+                                               true /* required */);
+  if (tmp == onc::wifi::kWEP_PSK)
+    return mojom::SecurityType::WEP_PSK;
+  else if (tmp == onc::wifi::kWEP_8021X)
+    return mojom::SecurityType::WEP_8021X;
+  else if (tmp == onc::wifi::kWPA_PSK)
+    return mojom::SecurityType::WPA_PSK;
+  else if (tmp == onc::wifi::kWPA_EAP)
+    return mojom::SecurityType::WPA_EAP;
+  else
+    return mojom::SecurityType::NONE;
+}
+
+mojom::WiFiPtr TranslateONCWifi(const base::DictionaryValue* dict) {
+  mojom::WiFiPtr mojo = mojom::WiFi::New();
+
+  // Optional; defaults to 0.
+  dict->GetInteger(onc::wifi::kFrequency, &mojo->frequency);
+
+  mojo->bssid =
+      GetStringFromOncDictionary(dict, onc::wifi::kBSSID, false /* required */);
+  mojo->hex_ssid = GetStringFromOncDictionary(dict, onc::wifi::kHexSSID,
+                                              true /* required */);
+
+  // Optional; defaults to false.
+  dict->GetBoolean(onc::wifi::kHiddenSSID, &mojo->hidden_ssid);
+
+  mojo->security = TranslateONCWifiSecurityType(dict);
+
+  // Optional; defaults to 0.
+  dict->GetInteger(onc::wifi::kSignalStrength, &mojo->signal_strength);
+
+  return mojo;
+}

[stevenjb, 2016/05/18 21:00:18]

All non member / non public functions should be in the anonymous namespace.

[Kevin Cernekee, 2016/05/18 21:36:58]

Done.

+
+mojo::Array<mojo::String> TranslateStringArray(const base::ListValue* list) {
+  mojo::Array<mojo::String> mojos = mojo::Array<mojo::String>::New(0);
+
+  for (size_t i = 0; i < list->GetSize(); i++) {
+    std::string tmp;
+    list->GetString(i, &tmp);
+    DCHECK(!tmp.empty());
+    mojos.push_back(static_cast<mojo::String>(tmp));
+  }
+
+  return mojos;
+}
+
+mojo::Array<mojom::IPConfigurationPtr> TranslateONCIPConfigs(
+    const base::ListValue* list) {
+  mojo::Array<mojom::IPConfigurationPtr> mojos =
+      mojo::Array<mojom::IPConfigurationPtr>::New(0);
+
+  for (size_t i = 0; i < list->GetSize(); i++) {
+    const base::DictionaryValue* ip_dict = nullptr;
+    mojom::IPConfigurationPtr mojo = mojom::IPConfiguration::New();
+
+    list->GetDictionary(i, &ip_dict);
+    DCHECK(ip_dict);
+
+    mojo->gateway = GetStringFromOncDictionary(ip_dict, onc::ipconfig::kGateway,
+                                               true /* required */);
+    mojo->ip_address = GetStringFromOncDictionary(
+        ip_dict, onc::ipconfig::kIPAddress, true /* required */);
+
+    const base::ListValue* dns_list;
+    if (!ip_dict->GetList(onc::ipconfig::kNameServers, &dns_list))
+      NOTREACHED();
+    mojo->name_servers = TranslateStringArray(dns_list);
+
+    if (!ip_dict->GetInteger(onc::ipconfig::kRoutingPrefix,
+                             &mojo->routing_prefix)) {
+      NOTREACHED();
+    }
+
+    std::string tmp = GetStringFromOncDictionary(ip_dict, onc::ipconfig::kType,
+                                                 true /* required */);
+    mojo->type = tmp == onc::ipconfig::kIPv6 ? mojom::IPAddressType::IPV6
+                                             : mojom::IPAddressType::IPV4;
+
+    mojo->web_proxy_auto_discovery_url = GetStringFromOncDictionary(
+        ip_dict, onc::ipconfig::kWebProxyAutoDiscoveryUrl, true /* required */);
+
+    mojos.push_back(std::move(mojo));
+  }
+  return mojos;
+}
+
+mojom::ConnectionStateType TranslateONCConnectionState(
+    const base::DictionaryValue* dict) {
+  std::string tmp = GetStringFromOncDictionary(
+      dict, onc::network_config::kConnectionState, true /* required */);
+
+  if (tmp == onc::connection_state::kConnected)
+    return mojom::ConnectionStateType::CONNECTED;
+  else if (tmp == onc::connection_state::kConnecting)
+    return mojom::ConnectionStateType::CONNECTING;
+  else if (tmp == onc::connection_state::kNotConnected)
+    return mojom::ConnectionStateType::NOT_CONNECTED;
+
+  NOTREACHED();
+  return mojom::ConnectionStateType::NOT_CONNECTED;
+}
+
+void TranslateONCNetworkTypeDetails(const base::DictionaryValue* dict,
+                                    mojom::NetworkConfiguration* mojo) {
+  std::string tmp = GetStringFromOncDictionary(dict, onc::network_config::kType,
+                                               true /* required */);
+  if (tmp == onc::network_type::kCellular) {
+    mojo->type = mojom::NetworkType::CELLULAR;
+  } else if (tmp == onc::network_type::kEthernet) {
+    mojo->type = mojom::NetworkType::ETHERNET;
+  } else if (tmp == onc::network_type::kVPN) {
+    mojo->type = mojom::NetworkType::VPN;
+  } else if (tmp == onc::network_type::kWiFi) {
+    mojo->type = mojom::NetworkType::WIFI;
+
+    const base::DictionaryValue* wifi_dict = nullptr;
+    dict->GetDictionary(onc::network_config::kWiFi, &wifi_dict);
+    DCHECK(wifi_dict);
+    mojo->wifi = TranslateONCWifi(wifi_dict);
+  } else if (tmp == onc::network_type::kWimax) {
+    mojo->type = mojom::NetworkType::WIMAX;
+  } else {
+    NOTREACHED();
+  }

[stevenjb, 2016/05/18 21:00:18]

I think this would be simpler / more clear if it returned a mojo type. (Would
need to return a default value after NOTREACHED() but that is sometimes
unavoidable).

[Kevin Cernekee, 2016/05/18 21:36:58]

It is also setting mojo->wifi (and will someday set the equivalent fields for
ethernet, cellular, etc.).

+}
+
+mojom::NetworkConfigurationPtr TranslateONCConfiguration(
+    const base::DictionaryValue* dict) {
+  mojom::NetworkConfigurationPtr mojo = mojom::NetworkConfiguration::New();
+
+  mojo->connection_state = TranslateONCConnectionState(dict);
+
+  mojo->guid = GetStringFromOncDictionary(dict, onc::network_config::kGUID,
+                                          true /* required */);
+
+  const base::ListValue* ip_config_list = nullptr;
+  if (dict->GetList(onc::network_config::kIPConfigs, &ip_config_list)) {
+    DCHECK(ip_config_list);
+    mojo->ip_configs = TranslateONCIPConfigs(ip_config_list);
+  }
+
+  mojo->guid = GetStringFromOncDictionary(dict, onc::network_config::kGUID,
+                                          true /* required */);
+  mojo->mac_address = GetStringFromOncDictionary(
+      dict, onc::network_config::kMacAddress, true /* required */);
+  TranslateONCNetworkTypeDetails(dict, mojo.get());
+
+  return mojo;
+}
+
+void GetDefaultNetworkSuccessCallback(
+    const ArcNetHostImpl::GetDefaultNetworkCallback& callback,
+    const std::string& service_path,
+    const base::DictionaryValue& dictionary) {
+  // TODO(cernekee): Figure out how to query Chrome for the default physical
+  // service if a VPN is connected, rather than just reporting the
+  // default logical service in both fields.
+  callback.Run(TranslateONCConfiguration(&dictionary),
+               TranslateONCConfiguration(&dictionary));
+}
+
+void GetDefaultNetworkFailureCallback(
+    const ArcNetHostImpl::GetDefaultNetworkCallback& callback,
+    const std::string& error_name,
+    std::unique_ptr<base::DictionaryValue> error_data) {
+  LOG(ERROR) << "Failed to query default logical network";
+  callback.Run(nullptr, nullptr);
+}
+
+void ArcNetHostImpl::GetDefaultNetwork(
+    const GetDefaultNetworkCallback& callback) {
+  const chromeos::NetworkState* default_network =
+      GetStateHandler()->DefaultNetwork();
+  if (!default_network) {
+    VLOG(1) << "GetDefaultNetwork: no default network";
+    callback.Run(nullptr, nullptr);
+    return;
+  }
+  VLOG(1) << "GetDefaultNetwork: default network is "
+          << default_network->path();
+  std::string user_id_hash = chromeos::LoginState::Get()->primary_user_hash();
+  GetManagedConfigurationHandler()->GetProperties(
+      user_id_hash, default_network->path(),
+      base::Bind(&GetDefaultNetworkSuccessCallback, callback),
+      base::Bind(&GetDefaultNetworkFailureCallback, callback));
+}
+
+void DefaultNetworkSuccessCallback(ArcNetHostImpl* instance,
+                                   const std::string& service_path,
+                                   const base::DictionaryValue& dictionary) {
+  instance->arc_bridge_service()->net_instance()->DefaultNetworkChanged(
+      TranslateONCConfiguration(&dictionary),
+      TranslateONCConfiguration(&dictionary));
+}
+
+void DefaultNetworkFailureCallback(
+    const std::string& error_name,
+    std::unique_ptr<base::DictionaryValue> error_data) {
+  LOG(ERROR) << "Failed to query default logical network";
+}
+
+void ArcNetHostImpl::DefaultNetworkChanged(
+    const chromeos::NetworkState* network) {
+  if (arc_bridge_service()->net_version() < 2) {
+    VLOG(1) << "ArcBridgeService does not support DefaultNetworkChanged.";
+    return;
+  }
+
+  if (!network) {
+    VLOG(1) << "No default network";
+    arc_bridge_service()->net_instance()->DefaultNetworkChanged(nullptr,
+                                                                nullptr);
+    return;
+  }
+
+  VLOG(1) << "New default network: " << network->path();
+  std::string user_id_hash = chromeos::LoginState::Get()->primary_user_hash();
+  GetManagedConfigurationHandler()->GetProperties(
+      user_id_hash, network->path(),
+      base::Bind(&DefaultNetworkSuccessCallback, base::Unretained(this)),
+      base::Bind(&DefaultNetworkFailureCallback));
+}
+
 void ArcNetHostImpl::OnShuttingDown() {
   GetStateHandler()->RemoveObserver(this, FROM_HERE);
 }
 
 }  // namespace arc