third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp - Issue 1925043002: Clean up ShadowRootRareData, ShadowRoot and SlotAssignment

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp

Issue 1925043002: Clean up ShadowRootRareData, ShadowRoot and SlotAssignment (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: make stylesheet() return reference Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/dom/DocumentOrShadowRoot.h ('k') | third_party/WebKit/Source/core/dom/shadow/ShadowRoot.h » ('j') | third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp

diff --git a/third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp b/third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp

index 393a0eae0cf5616eb33844ae44059fa123cfad97..88234560d230aee74a91d3b2ef28e10d921e2d0f 100644

--- a/third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp

+++ b/third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp

@@ -234,14 +234,14 @@ bool ElementShadow::hasSameStyles(const ElementShadow* other) const

if (!root || !otherRoot)

return false;

- StyleSheetList* list = root->styleSheets();

- StyleSheetList* otherList = otherRoot->styleSheets();

+ StyleSheetList& list = root->styleSheets();

+ StyleSheetList& otherList = otherRoot->styleSheets();

- if (list->length() != otherList->length())

+ if (list.length() != otherList.length())

return false;

- for (size_t i = 0; i < list->length(); i++) {

- if (toCSSStyleSheet(list->item(i))->contents() != toCSSStyleSheet(otherList->item(i))->contents())

+ for (size_t i = 0; i < list.length(); i++) {

+ if (toCSSStyleSheet(list.item(i))->contents() != toCSSStyleSheet(otherList.item(i))->contents())

return false;

}

root = root->olderShadowRoot();