Clean up ShadowRootRareData, ShadowRoot and SlotAssignment

Clean up ShadowRootRareData, ShadowRoot and SlotAssignment

A lot of data are being scattered in these classes.

To make it clean and their responsibilities clear, remove ShadowRootRareData,
then move data owned by it into other classes:

- Make SlotAssignment have a responsibility of managing all data related to slot assignments
- Other data are now owned by ShadowRoot directly

BUG=531990
Committed: https://crrev.com/affcdceef73880b9b2d3b7a889e9da01bca26b8b
Cr-Commit-Position: refs/heads/master@{#390345}

[hayato, 2016-04-28 07:37:53]

The CQ bit was checked by hayato@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-28 07:38:03]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1925043002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1925043002/1

[hayato, 2016-04-28 07:43:56]

Description was changed from

==========
Move rare data to either SlotAssignment or ShadowRoot

BUG=
==========

to

==========
Clean up ShadowRootRareData, ShadowRoot and SlotAssignment

A lot of data are being scattered in these classes.

To make it clean and their responsibilities clear, remove ShadowRootRareData,
then move data owned by it into other classes:

- Make SlotAssignment have a responsibility of managing all data related to
slots
- Make ShadowRoot have data which are not related to slots

BUG=531990
==========

[hayato, 2016-04-28 07:45:36]

Description was changed from

==========
Clean up ShadowRootRareData, ShadowRoot and SlotAssignment

A lot of data are being scattered in these classes.

To make it clean and their responsibilities clear, remove ShadowRootRareData,
then move data owned by it into other classes:

- Make SlotAssignment have a responsibility of managing all data related to
slots
- Make ShadowRoot have data which are not related to slots

BUG=531990
==========

to

==========
Clean up ShadowRootRareData, ShadowRoot and SlotAssignment

A lot of data are being scattered in these classes.

To make it clean and their responsibilities clear, remove ShadowRootRareData,
then move data owned by it into other classes:

- Make SlotAssignment have a responsibility of managing all data related to slot
assignments
- Other data are now owned by ShadowRoot directly

BUG=531990
==========

[commit-bot: I haz the power, 2016-04-28 07:56:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-28 07:56:18]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[hayato, 2016-04-28 08:03:07]

The CQ bit was checked by hayato@chromium.org to run a CQ dry run

[hayato, 2016-04-28 08:03:11]

make stylesheet() return reference

[commit-bot: I haz the power, 2016-04-28 08:03:16]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1925043002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1925043002/20001

[hayato, 2016-04-28 08:05:45]

hayato@chromium.org changed reviewers:
+ kochi@chromium.org, tkent@chromium.org

[hayato, 2016-04-28 08:05:45]

PTAL

[commit-bot: I haz the power, 2016-04-28 08:22:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-28 08:22:11]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[kochi, 2016-04-28 08:36:37]

https://codereview.chromium.org/1925043002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp (right):

https://codereview.chromium.org/1925043002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp:47: struct
SameSizeAsShadowRoot : public DocumentFragment, public TreeScope {
Looks you need to update this as well.

https://codereview.chromium.org/1925043002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/shadow/SlotAssignment.h (right):

https://codereview.chromium.org/1925043002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/shadow/SlotAssignment.h:44: unsigned
m_descendantSlotCount;
C++11-style initialization for members are allowed, thus this line can be
unsigned m_descendantSlotCount = 0;

then you can remove the definition of the constructor in .cpp file.

https://codereview.chromium.org/1925043002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/shadow/SlotAssignment.h:47: 
nit: unnecessary newline?

[hayato, 2016-04-28 08:59:24]

The CQ bit was checked by hayato@chromium.org to run a CQ dry run

[hayato, 2016-04-28 08:59:25]

fixed

[commit-bot: I haz the power, 2016-04-28 08:59:47]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1925043002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1925043002/40001

[hayato, 2016-04-28 09:02:00]

I have updated bit-fields. Now ShadowRoot should have the same size.

https://codereview.chromium.org/1925043002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/shadow/SlotAssignment.h (right):

https://codereview.chromium.org/1925043002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/shadow/SlotAssignment.h:44: unsigned
m_descendantSlotCount;
Done

https://codereview.chromium.org/1925043002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/shadow/SlotAssignment.h:47: 
Done

[kochi, 2016-04-28 09:31:18]

lgtm

[hayato, 2016-04-28 09:35:58]

The CQ bit was unchecked by hayato@chromium.org

[hayato, 2016-04-28 09:36:02]

The CQ bit was checked by hayato@chromium.org

[commit-bot: I haz the power, 2016-04-28 09:36:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1925043002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1925043002/40001

[commit-bot: I haz the power, 2016-04-28 10:57:25]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-30 17:17:28]

Patchset 3 (id:??) landed as
https://crrev.com/affcdceef73880b9b2d3b7a889e9da01bca26b8b
Cr-Commit-Position: refs/heads/master@{#390345}

[commit-bot: I haz the power, 2016-04-30 17:55:08]

Description was changed from

==========
Clean up ShadowRootRareData, ShadowRoot and SlotAssignment

A lot of data are being scattered in these classes.

To make it clean and their responsibilities clear, remove ShadowRootRareData,
then move data owned by it into other classes:

- Make SlotAssignment have a responsibility of managing all data related to slot
assignments
- Other data are now owned by ShadowRoot directly

BUG=531990
==========

to

==========
Clean up ShadowRootRareData, ShadowRoot and SlotAssignment

A lot of data are being scattered in these classes.

To make it clean and their responsibilities clear, remove ShadowRootRareData,
then move data owned by it into other classes:

- Make SlotAssignment have a responsibility of managing all data related to slot
assignments
- Other data are now owned by ShadowRoot directly

BUG=531990

Committed: https://crrev.com/affcdceef73880b9b2d3b7a889e9da01bca26b8b
Cr-Commit-Position: refs/heads/master@{#390345}
==========