Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2249)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_service.h

Issue 1924983002: Enable V4LocalDatabaseManager based on Finch. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/safe_browsing_service.h
diff --git a/chrome/browser/safe_browsing/safe_browsing_service.h b/chrome/browser/safe_browsing/safe_browsing_service.h
index f5de477ca7427f03539b00ab01e261614c196733..c70bea2384ec74633587c038a59dd1b2bd9897d9 100644
--- a/chrome/browser/safe_browsing/safe_browsing_service.h
+++ b/chrome/browser/safe_browsing/safe_browsing_service.h
@@ -55,6 +55,7 @@ class SafeBrowsingProtocolManagerDelegate;
class SafeBrowsingServiceFactory;
class SafeBrowsingUIManager;
class SafeBrowsingURLRequestContextGetter;
+class V4LocalDatabaseManager;
struct V4ProtocolConfig;
#if defined(FULL_SAFE_BROWSING)
@@ -176,6 +177,8 @@ class SafeBrowsingService : public base::RefCountedThreadSafe<
virtual SafeBrowsingDatabaseManager* CreateDatabaseManager();
+ virtual V4LocalDatabaseManager* CreateV4LocalDatabaseManager();
+
virtual SafeBrowsingUIManager* CreateUIManager();
// Registers all the delayed analysis with the incident reporting service.
@@ -237,6 +240,9 @@ class SafeBrowsingService : public base::RefCountedThreadSafe<
// Process the observed resource requests on the UI thread.
void ProcessResourceRequest(const ResourceRequestInfo& request);
+ // Is the Pver4 database manager enabled? Controlled by Finch.
+ bool IsV4LocalDatabaseManagerEnabled();
+
// The factory used to instanciate a SafeBrowsingService object.
// Useful for tests, so they can provide their own implementation of
// SafeBrowsingService.
@@ -282,6 +288,10 @@ class SafeBrowsingService : public base::RefCountedThreadSafe<
// both UI and IO thread.
scoped_refptr<SafeBrowsingDatabaseManager> database_manager_;
+ // The Pver4 local database manager handles the database and download logic
+ // Accessed on both UI and IO thread.
+ scoped_refptr<V4LocalDatabaseManager> v4_local_database_manager_;
+
DISALLOW_COPY_AND_ASSIGN(SafeBrowsingService);
};

Powered by Google App Engine
This is Rietveld 408576698