Issue 1924943003: fix build by using ifdef instead of if for SK_DEBUG

reed1

Description was changed from ========== BUG=skia: ========== to ========== BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1924943003 ==========

4 years, 7 months ago (2016-04-28 01:41:49 UTC) #1

reed1

Description was changed from ========== BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1924943003 ========== to ========== BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1924943003 TBR= ...

4 years, 7 months ago (2016-04-28 01:42:28 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1924943003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1924943003/1

4 years, 7 months ago (2016-04-28 01:42:41 UTC) #4

reed1

Description was changed from ========== BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1924943003 TBR= ========== to ========== BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1924943003 ...

4 years, 7 months ago (2016-04-28 01:45:48 UTC) #8

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1924943003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1924943003/1

4 years, 7 months ago (2016-04-28 01:46:01 UTC) #10

commit-bot: I haz the power

Description was changed from ========== BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1924943003 TBR= NOTRY=True ========== to ========== BUG=skia: GOLD_TRYBOT_URL= ...

4 years, 7 months ago (2016-04-28 01:46:48 UTC) #11

commit-bot: I haz the power

Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/b8498825b54718cdd90c30c39323cfc433695f23

4 years, 7 months ago (2016-04-28 01:46:49 UTC) #12

reed1

Description was changed from ========== BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1924943003 TBR= NOTRY=True Committed: https://skia.googlesource.com/skia/+/b8498825b54718cdd90c30c39323cfc433695f23 ========== to ========== ...

4 years, 7 months ago (2016-04-28 01:49:47 UTC) #13

reed1

4 years, 7 months ago (2016-04-28 15:11:35 UTC) #14

Message was sent while issue was closed.

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1927113002/ by reed@google.com.

The reason for reverting is: need to revert main change for now.

Issue 1924943003: fix build by using ifdef instead of if for SK_DEBUG (Closed)

Description

Patch Set 1 #

Messages