Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h

Issue 1924913002: [DevTools] Move API methods from V8DebuggerAgent to V8InspectorSession. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h
diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h b/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h
index a0cd63adba4d750599657300a1daac8e04cb88f8..5c2425fd583c038d88c955f3a7724b8359abc0f4 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h
+++ b/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h
@@ -56,7 +56,6 @@ public:
void enable(ErrorString*) override;
void setBreakpointsActive(ErrorString*, bool active) override;
void setSkipAllPauses(ErrorString*, bool skipped) override;
-
void setBreakpointByUrl(ErrorString*,
int lineNumber,
const Maybe<String16>& optionalURL,
@@ -135,23 +134,22 @@ public:
const String16& scriptId,
PassOwnPtr<protocol::Array<protocol::Debugger::ScriptPosition>> positions) override;
- void schedulePauseOnNextStatement(const String16& breakReason, PassOwnPtr<protocol::DictionaryValue> data) override;
- void cancelPauseOnNextStatement() override;
- void breakProgram(const String16& breakReason, PassOwnPtr<protocol::DictionaryValue> data) override;
- void breakProgramOnException(const String16& breakReason, PassOwnPtr<protocol::DictionaryValue> data) override;
-
bool enabled();
- V8DebuggerImpl& debugger() override { return *m_debugger; }
+ V8DebuggerImpl& debugger() { return *m_debugger; }
void setBreakpointAt(const String16& scriptId, int lineNumber, int columnNumber, BreakpointSource, const String16& condition = String16());
void removeBreakpointAt(const String16& scriptId, int lineNumber, int columnNumber, BreakpointSource);
+ void schedulePauseOnNextStatement(const String16& breakReason, PassOwnPtr<protocol::DictionaryValue> data);
+ void cancelPauseOnNextStatement();
+ void breakProgram(const String16& breakReason, PassOwnPtr<protocol::DictionaryValue> data);
+ void breakProgramOnException(const String16& breakReason, PassOwnPtr<protocol::DictionaryValue> data);
// Async call stacks implementation.
- void asyncTaskScheduled(const String16& taskName, void* task, bool recurring) override;
- void asyncTaskCanceled(void* task) override;
- void asyncTaskStarted(void* task) override;
- void asyncTaskFinished(void* task) override;
- void allAsyncTasksCanceled() override;
+ void asyncTaskScheduled(const String16& taskName, void* task, bool recurring);
+ void asyncTaskCanceled(void* task);
+ void asyncTaskStarted(void* task);
+ void asyncTaskFinished(void* task);
+ void allAsyncTasksCanceled();
void reset();

Powered by Google App Engine
This is Rietveld 408576698