Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 1924893003: Views: Replace View::focusable() with View::focus_behavior(). (Closed)

Created:
4 years, 7 months ago by karandeepb
Modified:
4 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@SetFocusBehavior
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Views: Replace View::focusable() with View::focus_behavior(). Committed: https://crrev.com/394e619bfe27f5e996a8de161cb611038be0c5ca Cr-Commit-Position: refs/heads/master@{#390557}

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -11 lines) Patch
M ui/views/controls/label.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/view.h View 1 1 chunk +2 lines, -3 lines 0 comments Download
M ui/views/view_unittest.cc View 2 chunks +8 lines, -6 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (4 generated)
karandeepb
PTAL sky@. Thanks.
4 years, 7 months ago (2016-04-28 06:56:25 UTC) #3
sky
LGTM - sorry for not being clear that this is what I was asking for.
4 years, 7 months ago (2016-04-28 23:47:08 UTC) #4
karandeepb
On 2016/04/28 23:47:08, sky wrote: > LGTM - sorry for not being clear that this ...
4 years, 7 months ago (2016-04-29 00:19:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1924893003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1924893003/40001
4 years, 7 months ago (2016-04-29 00:20:14 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 7 months ago (2016-04-29 01:25:19 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:23:18 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/394e619bfe27f5e996a8de161cb611038be0c5ca
Cr-Commit-Position: refs/heads/master@{#390557}

Powered by Google App Engine
This is Rietveld 408576698