👓 Allow instrumentation test filters to use fully-qualified class names

Allow instrumentation test filters to use fully-qualified class names

This has tripped me a few times since test output often outputs the
fully-qualified class name.

BUG=none

Committed: https://crrev.com/aba9829080d8e4f57da98c52119b7a26ee825a15
Cr-Commit-Position: refs/heads/master@{#390201}

[agrieve, 2016-04-27 19:28:10]

Description was changed from

==========
Allow instrumentation test filters to use fully-qualified class names

This has tripped me a few times since test output often outputs the
fully-qualified class name.

BUG=none
==========

to

==========
Allow instrumentation test filters to use fully-qualified class names

This has tripped me a few times since test output often outputs the
fully-qualified class name.

BUG=none
==========

[agrieve, 2016-04-27 19:28:10]

agrieve@chromium.org changed reviewers:
+ jbudorick@chromium.org

[agrieve, 2016-04-27 19:28:16]

On 2016/04/27 19:28:10, agrieve wrote:
> mailto:agrieve@chromium.org changed reviewers:
> + mailto:jbudorick@chromium.org

[jbudorick, 2016-04-27 19:31:40]

https://codereview.chromium.org/1924893002/diff/1/build/android/pylib/instrum...
File build/android/pylib/instrumentation/instrumentation_test_instance.py
(right):

https://codereview.chromium.org/1924893002/diff/1/build/android/pylib/instrum...
build/android/pylib/instrumentation/instrumentation_test_instance.py:551: t1 =
['%s.%s' % (c['class'], m['method'])]
Could this instead just be

  t = ['%s.%s' % (c['class'], m['method']), '%s.%s' %(c['class'].split('.')[-1],
m['method'])]
  return unittest_util.FilterTestNames(t, self._test_filter)

?

[agrieve, 2016-04-27 19:42:04]

https://codereview.chromium.org/1924893002/diff/1/build/android/pylib/instrum...
File build/android/pylib/instrumentation/instrumentation_test_instance.py
(right):

https://codereview.chromium.org/1924893002/diff/1/build/android/pylib/instrum...
build/android/pylib/instrumentation/instrumentation_test_instance.py:551: t1 =
['%s.%s' % (c['class'], m['method'])]
On 2016/04/27 19:31:40, jbudorick wrote:
> Could this instead just be
> 
>   t = ['%s.%s' % (c['class'], m['method']), '%s.%s'
%(c['class'].split('.')[-1],
> m['method'])]
>   return unittest_util.FilterTestNames(t, self._test_filter)
> 
> ? 
> 
>   

Done.

[jbudorick, 2016-04-27 20:05:38]

lgtm

[agrieve, 2016-04-27 20:34:08]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2016-04-27 20:34:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1924893002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1924893002/20001

[commit-bot: I haz the power, 2016-04-27 21:46:35]

Description was changed from

==========
Allow instrumentation test filters to use fully-qualified class names

This has tripped me a few times since test output often outputs the
fully-qualified class name.

BUG=none
==========

to

==========
Allow instrumentation test filters to use fully-qualified class names

This has tripped me a few times since test output often outputs the
fully-qualified class name.

BUG=none
==========

[commit-bot: I haz the power, 2016-04-27 21:46:36]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-30 17:13:34]

Patchset 2 (id:??) landed as
https://crrev.com/aba9829080d8e4f57da98c52119b7a26ee825a15
Cr-Commit-Position: refs/heads/master@{#390201}

[commit-bot: I haz the power, 2016-04-30 17:52:12]

Description was changed from

==========
Allow instrumentation test filters to use fully-qualified class names

This has tripped me a few times since test output often outputs the
fully-qualified class name.

BUG=none
==========

to

==========
Allow instrumentation test filters to use fully-qualified class names

This has tripped me a few times since test output often outputs the
fully-qualified class name.

BUG=none

Committed: https://crrev.com/aba9829080d8e4f57da98c52119b7a26ee825a15
Cr-Commit-Position: refs/heads/master@{#390201}
==========