Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(725)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1924863002: Rescoping prior profile data in Autofill settings to correct regression. (Closed)

Created:
4 years, 7 months ago by tmartino
Modified:
4 years, 7 months ago
Reviewers:
Mathieu, stevenjb
CC:
bondd+autofillwatch_chromium.org, chromium-reviews, dbeam+watch-options_chromium.org, estade+watch_chromium.org, jdonnelly+autofillwatch_chromium.org, michaelpg+watch-options_chromium.org, rouslan+autofill_chromium.org, vabr+watchlistautofill_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rescoping prior profile data in Autofill settings to correct regression. BUG=607071 Committed: https://crrev.com/1e5379ebd8051916ea19707068871a14f29164d1 Cr-Commit-Position: refs/heads/master@{#390142}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -18 lines) Patch
M chrome/browser/ui/webui/options/autofill_options_handler.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/options/autofill_options_handler.cc View 4 chunks +18 lines, -14 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1924863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1924863002/1
4 years, 7 months ago (2016-04-27 17:41:42 UTC) #2
tmartino
Hi mathp, stevenjb, You reviewed a CL of mine, https://codereview.chromium.org/1868003003, which introduced a small crashing ...
4 years, 7 months ago (2016-04-27 18:03:50 UTC) #4
stevenjb
owner lgtm
4 years, 7 months ago (2016-04-27 18:23:19 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-04-27 18:30:58 UTC) #7
Mathieu
Thanks for jumping on this, lgtm
4 years, 7 months ago (2016-04-27 18:55:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1924863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1924863002/1
4 years, 7 months ago (2016-04-27 19:00:22 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-27 19:06:27 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:11:42 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/1e5379ebd8051916ea19707068871a14f29164d1
Cr-Commit-Position: refs/heads/master@{#390142}

Powered by Google App Engine
This is Rietveld 408576698