Issue 1924843002: Motown: Remove ffmpeg_branding arg to fix fnl build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1924843002: Motown: Remove ffmpeg_branding arg to fix fnl build. (Closed)

Created:
4 years, 7 months ago by dalesat

Modified:
4 years, 7 months ago

Reviewers:
vtl, cdotstout, kulakowski, viettrungluu

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Motown: Remove ffmpeg_branding arg to fix fnl build. R=viettrungluu@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/74d7993f1c37589b4eaf3693374d160b51fc685b

Patch Set 1 #

Patch Set 2 : Remove bogus BUILDCONFIG.gn change. #

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -6 lines)			Patch
	M	mojo/tools/mopy/gn.py	View		1 chunk	+0 lines, -3 lines	0 comments	Download
	M	mojo/tools/mopy/gn_unittest.py	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

dalesat

4 years, 7 months ago (2016-04-27 17:42:23 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
74d7993f1c37589b4eaf3693374d160b51fc685b (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages