Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 192483007: Move chromeos/display/* to ui/display/chromeos (Closed)

Created:
6 years, 9 months ago by dnicoara
Modified:
6 years, 9 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, sadrul, nkostylev+watch_chromium.org, derat+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, kalyank, stevenjb+watch_chromium.org, ben+ash_chromium.org, marcheu
Visibility:
Public.

Description

Move chromeos/display/* to ui/display/chromeos TBR=darin@chromium.org BUG=333413 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257197

Patch Set 1 #

Patch Set 2 : Fix formatting #

Total comments: 5

Patch Set 3 : Changing dependency formatting #

Patch Set 4 : Update deps #

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : remove sque #

Patch Set 8 : Rebased #

Patch Set 9 : Rebased #

Patch Set 10 : Include display.gyp into ChromeOS builds only #

Unified diffs Side-by-side diffs Delta from patch set Stats (+795 lines, -5421 lines) Patch
M ash/ash.gyp View 1 2 3 4 5 6 7 8 9 2 chunks +4 lines, -2 lines 0 comments Download
M ash/display/display_change_observer_chromeos.h View 2 chunks +9 lines, -11 lines 0 comments Download
M ash/display/display_change_observer_chromeos.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M ash/display/display_change_observer_chromeos_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/display/display_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/display/display_error_observer_chromeos.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/display/display_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/display/display_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/display/event_transformation_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/display/output_configurator_animation.h View 3 chunks +6 lines, -7 lines 0 comments Download
M ash/display/output_configurator_animation.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/display/projecting_observer_chromeos.h View 2 chunks +3 lines, -4 lines 0 comments Download
M ash/display/projecting_observer_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/display/projecting_observer_chromeos_unittest.cc View 11 chunks +14 lines, -14 lines 0 comments Download
M ash/shell.h View 1 2 3 4 5 6 7 4 chunks +3 lines, -5 lines 0 comments Download
M ash/shell.cc View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download
M ash/system/chromeos/power/power_event_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/test/shell_test_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/touch/touch_observer_hud.h View 3 chunks +9 lines, -11 lines 0 comments Download
M ash/touch/touch_observer_hud.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/lock_state_controller_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ash/wm/power_button_controller.h View 3 chunks +6 lines, -7 lines 0 comments Download
M ash/wm/power_button_controller.cc View 1 2 3 4 5 6 7 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/dbus/display_power_service_provider.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/display/display_preferences.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/display/display_preferences_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/lifetime/application_lifetime_aura.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/renderer_host/pepper/pepper_output_protection_message_filter.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/renderer_host/pepper/pepper_output_protection_message_filter.cc View 8 chunks +13 lines, -13 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/display_options_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/chromeos.gyp View 1 2 3 4 5 6 7 4 chunks +0 lines, -28 lines 0 comments Download
D chromeos/display/OWNERS View 1 chunk +0 lines, -4 lines 0 comments Download
D chromeos/display/native_display_delegate.h View 1 chunk +0 lines, -82 lines 0 comments Download
D chromeos/display/native_display_delegate_x11.h View 1 chunk +0 lines, -133 lines 0 comments Download
D chromeos/display/native_display_delegate_x11.cc View 1 chunk +0 lines, -571 lines 0 comments Download
D chromeos/display/native_display_event_dispatcher_x11.h View 1 chunk +0 lines, -42 lines 0 comments Download
D chromeos/display/native_display_event_dispatcher_x11.cc View 1 chunk +0 lines, -73 lines 0 comments Download
D chromeos/display/native_display_event_dispatcher_x11_unittest.cc View 1 chunk +0 lines, -232 lines 0 comments Download
D chromeos/display/native_display_observer.h View 1 chunk +0 lines, -21 lines 0 comments Download
D chromeos/display/output_configurator.h View 1 chunk +0 lines, -450 lines 0 comments Download
D chromeos/display/output_configurator.cc View 1 chunk +0 lines, -1053 lines 0 comments Download
D chromeos/display/output_configurator_unittest.cc View 1 chunk +0 lines, -1434 lines 0 comments Download
D chromeos/display/output_util.h View 1 chunk +0 lines, -73 lines 0 comments Download
D chromeos/display/output_util.cc View 1 chunk +0 lines, -176 lines 0 comments Download
D chromeos/display/output_util_unittest.cc View 1 chunk +0 lines, -143 lines 0 comments Download
D chromeos/display/touchscreen_delegate_x11.h View 1 chunk +0 lines, -35 lines 0 comments Download
D chromeos/display/touchscreen_delegate_x11.cc View 1 chunk +0 lines, -174 lines 0 comments Download
M ui/display/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M ui/display/OWNERS View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
A + ui/display/chromeos/native_display_delegate.h View 2 chunks +8 lines, -8 lines 0 comments Download
A + ui/display/chromeos/native_display_observer.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + ui/display/chromeos/output_configurator.h View 17 chunks +38 lines, -41 lines 0 comments Download
A + ui/display/chromeos/output_configurator.cc View 1 41 chunks +160 lines, -153 lines 0 comments Download
A + ui/display/chromeos/output_configurator_unittest.cc View 49 chunks +160 lines, -169 lines 0 comments Download
A ui/display/chromeos/x11/display_util.h View 1 chunk +38 lines, -0 lines 0 comments Download
A + ui/display/chromeos/x11/display_util.cc View 5 chunks +39 lines, -53 lines 0 comments Download
A + ui/display/chromeos/x11/display_util_unittest.cc View 4 chunks +37 lines, -23 lines 0 comments Download
A + ui/display/chromeos/x11/native_display_delegate_x11.h View 3 chunks +6 lines, -6 lines 0 comments Download
A + ui/display/chromeos/x11/native_display_delegate_x11.cc View 15 chunks +40 lines, -63 lines 0 comments Download
A + ui/display/chromeos/x11/native_display_event_dispatcher_x11.h View 2 chunks +7 lines, -7 lines 0 comments Download
A + ui/display/chromeos/x11/native_display_event_dispatcher_x11.cc View 3 chunks +10 lines, -9 lines 0 comments Download
A + ui/display/chromeos/x11/native_display_event_dispatcher_x11_unittest.cc View 8 chunks +20 lines, -18 lines 0 comments Download
A + ui/display/chromeos/x11/touchscreen_delegate_x11.h View 2 chunks +6 lines, -6 lines 0 comments Download
A + ui/display/chromeos/x11/touchscreen_delegate_x11.cc View 1 7 chunks +25 lines, -18 lines 0 comments Download
M ui/display/display.gyp View 1 2 3 4 5 1 chunk +28 lines, -1 line 0 comments Download
A ui/display/display_export.h View 1 chunk +37 lines, -0 lines 0 comments Download
A ui/display/display_unittests.gypi View 1 2 3 4 5 6 7 8 9 1 chunk +28 lines, -0 lines 0 comments Download
M ui/ui_unittests.gyp View 1 2 3 4 5 6 7 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
dnicoara
PTAL To keep the CL size small, I'm performing the migration of chromeos/display/* to ui/display/chromeos ...
6 years, 9 months ago (2014-03-10 20:29:43 UTC) #1
Daniel Erat
lgtm https://codereview.chromium.org/192483007/diff/10001/ui/display/OWNERS File ui/display/OWNERS (right): https://codereview.chromium.org/192483007/diff/10001/ui/display/OWNERS#newcode4 ui/display/OWNERS:4: sque@chromium.org Simon, you don't modify/review this code anymore, ...
6 years, 9 months ago (2014-03-11 01:57:01 UTC) #2
dnicoara
+ sky@ for OWNERS review of chrome/browser and ui/*gyp
6 years, 9 months ago (2014-03-11 14:10:20 UTC) #3
sky
https://codereview.chromium.org/192483007/diff/10001/ui/display/display_unittests.gypi File ui/display/display_unittests.gypi (right): https://codereview.chromium.org/192483007/diff/10001/ui/display/display_unittests.gypi#newcode9 ui/display/display_unittests.gypi:9: '<(DEPTH)/base/base.gyp:test_support_base', Is there a reason you need DEPTH instead ...
6 years, 9 months ago (2014-03-11 16:00:17 UTC) #4
dnicoara
https://codereview.chromium.org/192483007/diff/10001/ui/display/display_unittests.gypi File ui/display/display_unittests.gypi (right): https://codereview.chromium.org/192483007/diff/10001/ui/display/display_unittests.gypi#newcode9 ui/display/display_unittests.gypi:9: '<(DEPTH)/base/base.gyp:test_support_base', On 2014/03/11 16:00:18, sky wrote: > Is there ...
6 years, 9 months ago (2014-03-11 19:13:54 UTC) #5
sky
LGTM
6 years, 9 months ago (2014-03-11 19:18:51 UTC) #6
dnicoara
https://codereview.chromium.org/192483007/diff/10001/ui/display/OWNERS File ui/display/OWNERS (right): https://codereview.chromium.org/192483007/diff/10001/ui/display/OWNERS#newcode4 ui/display/OWNERS:4: sque@chromium.org On 2014/03/11 01:57:02, Daniel Erat wrote: > Simon, ...
6 years, 9 months ago (2014-03-12 13:38:53 UTC) #7
Daniel Erat
https://codereview.chromium.org/192483007/diff/10001/ui/display/OWNERS File ui/display/OWNERS (right): https://codereview.chromium.org/192483007/diff/10001/ui/display/OWNERS#newcode4 ui/display/OWNERS:4: sque@chromium.org On 2014/03/12 13:38:53, dnicoara wrote: > On 2014/03/11 ...
6 years, 9 months ago (2014-03-13 00:59:12 UTC) #8
dnicoara
+CC marcheu@chromium.org
6 years, 9 months ago (2014-03-13 18:29:58 UTC) #9
dnicoara
The CQ bit was checked by dnicoara@chromium.org
6 years, 9 months ago (2014-03-13 22:05:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dnicoara@chromium.org/192483007/150001
6 years, 9 months ago (2014-03-13 22:06:52 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-13 22:39:49 UTC) #12
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=55293
6 years, 9 months ago (2014-03-13 22:39:49 UTC) #13
dnicoara
Adding darin@ for DEPS changes.
6 years, 9 months ago (2014-03-13 22:56:37 UTC) #14
dnicoara
The CQ bit was checked by dnicoara@chromium.org
6 years, 9 months ago (2014-03-14 13:41:48 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dnicoara@chromium.org/192483007/150001
6 years, 9 months ago (2014-03-14 13:42:00 UTC) #16
commit-bot: I haz the power
6 years, 9 months ago (2014-03-14 21:09:02 UTC) #17
Message was sent while issue was closed. 
Change committed as 257197

Powered by Google App Engine
This is Rietveld 408576698