[Findit] Use heuristic analysis result for test try jobs(Findit side).

appengine/findit/waterfall/try_job_util.py

Index: appengine/findit/waterfall/try_job_util.py
diff --git a/appengine/findit/waterfall/try_job_util.py b/appengine/findit/waterfall/try_job_util.py
index 7273548b062a647cf0164c986d2f3ef8abcd2f86..f57607604a17de778bf6338175e4dd46ec536c20 100644
--- a/appengine/findit/waterfall/try_job_util.py
+++ b/appengine/findit/waterfall/try_job_util.py
@@ -132,14 +132,13 @@ def _GetFailedTargetsFromSignals(signals, master_name, builder_name):
   return compile_targets
 
 
-def _GetSuspectsForCompileFailureFromHeuristicResult(heuristic_result):
+def _GetSuspectsFromHeuristicResult(heuristic_result):
   suspected_revisions = []
   if not heuristic_result:
     return suspected_revisions
   for failure in heuristic_result.get('failures', []):
-    if failure['step_name'] == constants.COMPILE_STEP_NAME:
-      suspected_revisions = [c['revision'] for c in failure['suspected_cls']]
-  return suspected_revisions
+    suspected_revisions = [c['revision'] for c in failure['suspected_cls']]

[stgao, 2016/04/28 17:37:49]

I don't think this overwrite will be correct for tests.

For different step failures, there might be different culprit CLs, right?

[chanli, 2016/04/28 22:13:14]

Right... Good catch!

+  return list(set(suspected_revisions))
 
 
 def ScheduleTryJobIfNeeded(failure_info, signals, heuristic_result):
@@ -171,8 +170,7 @@ def ScheduleTryJobIfNeeded(failure_info, signals, heuristic_result):
         signals, master_name, builder_name)
                        if try_job_type == TryJobType.COMPILE else None)
     suspected_revisions = (
-        _GetSuspectsForCompileFailureFromHeuristicResult(heuristic_result)
-        if try_job_type == TryJobType.COMPILE else None)
+        _GetSuspectsFromHeuristicResult(heuristic_result))

[lijeffrey, 2016/04/27 23:34:08]

nit: does this fit on one line?

[chanli, 2016/04/28 17:36:04]

Done.

 
     pipeline = (
         swarming_tasks_to_try_job_pipeline.SwarmingTasksToTryJobPipeline(