Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7211)

Unified Diff: appengine/findit/waterfall/test/try_job_util_test.py

Issue 1924823003: [Findit] Use heuristic analysis result for test try jobs(Findit side). (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/waterfall/test/try_job_util_test.py
diff --git a/appengine/findit/waterfall/test/try_job_util_test.py b/appengine/findit/waterfall/test/try_job_util_test.py
index 65f58afd018607153b19bd295ca23bac3e0c5073..e6fc2fb45f7d2cef405a058848d479f0cac6db17 100644
--- a/appengine/findit/waterfall/test/try_job_util_test.py
+++ b/appengine/findit/waterfall/test/try_job_util_test.py
@@ -408,7 +408,7 @@ class TryJobUtilTest(wf_testcase.WaterfallTestCase):
signals, 'master1', 'builder1'),
['b.o'])
- def testGetSuspectsForCompileFailureFromHeuristicResult(self):
+ def testGetSuspectsFromHeuristicResult(self):
heuristic_result = {
'failures': [
{
@@ -423,12 +423,20 @@ class TryJobUtilTest(wf_testcase.WaterfallTestCase):
],
},
{
- 'step_name': 'steps'
+ 'step_name': 'steps',
+ 'suspected_cls': [
+ {
+ 'revision': 'r1',
+ },
+ {
+ 'revision': 'r2',
+ },
+ ],
},
]
}
expected_suspected_revisions = ['r1', 'r2']
self.assertEqual(
expected_suspected_revisions,
- try_job_util._GetSuspectsForCompileFailureFromHeuristicResult(
+ try_job_util._GetSuspectsFromHeuristicResult(
heuristic_result))
lijeffrey 2016/04/27 23:34:08 nit: does this fit on one line?
chanli 2016/04/28 17:36:04 Done.

Powered by Google App Engine
This is Rietveld 408576698