[Findit] Use heuristic analysis result for test try jobs(Findit side).

appengine/findit/waterfall/identify_try_job_culprit_pipeline.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from google.appengine.ext import ndb
 
 from common.git_repository import GitRepository
 from common.http_client_appengine import HttpClientAppengine as HttpClient
 from common.pipeline_wrapper import BasePipeline
 from model import analysis_status
@@ skipping 150 matching lines @@
     if not report:
       return None
 
     if report.get('culprit'):
       return report.get('culprit')
 
     return IdentifyTryJobCulpritPipeline._GetFailedRevisionFromResultsDict(
         report.get('result', {}))
 
   def _FindCulpritForEachTestFailure(self, blame_list, result):
-    # For test failures, the try job will run against every revision,
-    # so we need to traverse the result dict in chronological order to identify
-    # the culprits for each failed step or test.
+    # For test failures, we need to traverse the result dict in chronological
+    # order to identify the culprits for each failed step or test.
+    # The earliest revision that a test failed is the culprit.
     culprit_map = {}
     failed_revisions = []
+    test_results = result['report'].get('result')
+
     for revision in blame_list:
-      test_results = result['report'].get('result')
+      if not test_results.get(revision):

[stgao, 2016/05/04 21:40:18]

How about let the recipe compute the culprits it finds for each test?

In that case, the recipe could change the way how it tests without impacting the
logic here. WDYT?

[chanli, 2016/05/04 23:41:37]

Done.

+        continue
 
       for step, test_result in test_results[revision].iteritems():
         if (not test_result['valid'] or
             test_result['status'] != 'failed'):  # pragma: no cover
           continue
 
         if revision not in failed_revisions:
           failed_revisions.append(revision)
 
         if step not in culprit_map:
@@ skipping 104 matching lines @@
         analysis.result_status = updated_result_status
         analysis.suspected_cls = updated_suspected_cls
         analysis.put()
 
     # Store try-job results.
     UpdateTryJobResult()
     # Add try-job results to WfAnalysis.
     UpdateWfAnalysisWithTryJobResult()
 
     return result.get('culprit') if result else None