ios/chrome/browser/history/history_backend_client_impl.cc - Issue 1924773002: TopSites: filter out non-WebSafe URLs

Side by Side Diff: ios/chrome/browser/history/history_backend_client_impl.cc

Issue 1924773002: TopSites: filter out non-WebSafe URLs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@topsites_cleanup

Patch Set: add test Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/history/core/browser/visitsegment_database.cc ('K') | « ios/chrome/browser/history/history_backend_client_impl.h ('k') | no next file » | no next file with comments »

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "ios/chrome/browser/history/history_backend_client_impl.h"	5 #include "ios/chrome/browser/history/history_backend_client_impl.h"

6	6

7 #include "components/bookmarks/browser/bookmark_model.h"	7 #include "components/bookmarks/browser/bookmark_model.h"

8 #include "url/gurl.h"	8 #include "url/gurl.h"

9	9

10 HistoryBackendClientImpl::HistoryBackendClientImpl(	10 HistoryBackendClientImpl::HistoryBackendClientImpl(

(...skipping 30 matching lines...) Expand all Loading...
41 bookmarks->reserve(bookmarks->size() + url_and_titles.size());	41 bookmarks->reserve(bookmarks->size() + url_and_titles.size());

42 for (const auto& url_and_title : url_and_titles) {	42 for (const auto& url_and_title : url_and_titles) {

43 history::URLAndTitle value = {url_and_title.url, url_and_title.title};	43 history::URLAndTitle value = {url_and_title.url, url_and_title.title};

44 bookmarks->push_back(value);	44 bookmarks->push_back(value);

45 }	45 }

46 }	46 }

47	47

48 bool HistoryBackendClientImpl::ShouldReportDatabaseError() {	48 bool HistoryBackendClientImpl::ShouldReportDatabaseError() {

49 return false;	49 return false;

50 }	50 }

	51

	52 bool HistoryBackendClientImpl::IsWebSafe(const GURL& url) {

	53 return true;
	Marc Treib 2016/05/02 15:29:44 On non-iOS, we check this via content::ChildProces On non-iOS, we check this via content::ChildProcessSecurityPolicy::IsWebSafeScheme, but I couldn't find anything equivalent on iOS. Do you know of something? sdefresne 2016/05/03 11:18:50 I think we do not have a dedicated method to do th Show quoted text On 2016/05/02 15:29:44, Marc Treib wrote: > On non-iOS, we check this via > content::ChildProcessSecurityPolicy::IsWebSafeScheme, but I couldn't find > anything equivalent on iOS. Do you know of something? I think we do not have a dedicated method to do that. We usually just check whether scheme is http or https (which are the two safe scheme among the few iOS supports), i.e.: return url.SchemeIs(url::kHttpScheme) \|\| url.SchemeIs(url::kHttpsScheme); Marc Treib 2016/05/03 11:51:17 GURL even has a SchemeIsHTTPOrHTTPS() method :) Ar Show quoted text On 2016/05/03 11:18:50, sdefresne wrote: > On 2016/05/02 15:29:44, Marc Treib wrote: > > On non-iOS, we check this via > > content::ChildProcessSecurityPolicy::IsWebSafeScheme, but I couldn't find > > anything equivalent on iOS. Do you know of something? > > I think we do not have a dedicated method to do that. We usually just check > whether scheme is http or https (which are the two safe scheme among the few iOS > supports), i.e.: > > return url.SchemeIs(url::kHttpScheme) \|\| url.SchemeIs(url::kHttpsScheme); GURL even has a SchemeIsHTTPOrHTTPS() method :) Are these really the only supported schemes though? I'd have expected at least FTP too? sdefresne 2016/05/03 12:03:39 No, Chrome on iOS does not support ftp:, nor file: Show quoted text On 2016/05/03 11:51:17, Marc Treib wrote: > On 2016/05/03 11:18:50, sdefresne wrote: > > On 2016/05/02 15:29:44, Marc Treib wrote: > > > On non-iOS, we check this via > > > content::ChildProcessSecurityPolicy::IsWebSafeScheme, but I couldn't find > > > anything equivalent on iOS. Do you know of something? > > > > I think we do not have a dedicated method to do that. We usually just check > > whether scheme is http or https (which are the two safe scheme among the few > iOS > > supports), i.e.: > > > > return url.SchemeIs(url::kHttpScheme) \|\| url.SchemeIs(url::kHttpsScheme); > > GURL even has a SchemeIsHTTPOrHTTPS() method :) > Are these really the only supported schemes though? I'd have expected at least > FTP too? No, Chrome on iOS does not support ftp:, nor file: schemes. It supports chrome:, http:, https:, data: and javascript: IIRC. Marc Treib 2016/05/03 12:15:10 Alright, thanks for the explanation! I suppose "da Show quoted text On 2016/05/03 12:03:39, sdefresne wrote: > On 2016/05/03 11:51:17, Marc Treib wrote: > > On 2016/05/03 11:18:50, sdefresne wrote: > > > On 2016/05/02 15:29:44, Marc Treib wrote: > > > > On non-iOS, we check this via > > > > content::ChildProcessSecurityPolicy::IsWebSafeScheme, but I couldn't find > > > > anything equivalent on iOS. Do you know of something? > > > > > > I think we do not have a dedicated method to do that. We usually just check > > > whether scheme is http or https (which are the two safe scheme among the few > > iOS > > > supports), i.e.: > > > > > > return url.SchemeIs(url::kHttpScheme) \|\| url.SchemeIs(url::kHttpsScheme); > > > > GURL even has a SchemeIsHTTPOrHTTPS() method :) > > Are these really the only supported schemes though? I'd have expected at least > > FTP too? > > No, Chrome on iOS does not support ftp:, nor file: schemes. It supports chrome:, > http:, https:, data: and javascript: IIRC. Alright, thanks for the explanation! I suppose "data:" could also be considered web-safe, but I don't see that ever coming up (and even if it did, it doesn't seem useful for TopSites).
	54 }

OLD	NEW