TopSites: filter out non-WebSafe URLs

components/history/core/browser/visitsegment_database.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_HISTORY_CORE_BROWSER_VISITSEGMENT_DATABASE_H_
 #define COMPONENTS_HISTORY_CORE_BROWSER_VISITSEGMENT_DATABASE_H_
 
 #include <memory>
 
+#include "base/callback.h"

[sdefresne, 2016/05/03 11:18:50]

nit: I think you can include "base/callback_forward.h" here and
"base/callback.h" in the implementation.

[Marc Treib, 2016/05/03 11:51:16]

Done.

 #include "base/macros.h"
 #include "components/history/core/browser/history_types.h"
 
 namespace sql {
 class Connection;
 }
 
 namespace history {
 
 class PageUsageData;
@@ skipping 25 matching lines @@
 
   // Create a segment for the provided URL ID with the given name. Returns the
   // ID of the newly created segment, or 0 on failure.
   SegmentID CreateSegment(URLID url_id, const std::string& segment_name);
 
   // Increase the segment visit count by the provided amount. Return true on
   // success.
   bool IncreaseSegmentVisitCount(SegmentID segment_id, base::Time ts,
                                  int amount);
 
-  // Computes the segment usage since |from_time|.
+  // Computes the segment usage since |from_time|. If |url_filter| is non-null,
+  // then only URLs for which it returns true will be included.
   // Returns the highest-scored segments up to |max_result_count|.
   std::vector<std::unique_ptr<PageUsageData>> QuerySegmentUsage(
       base::Time from_time,
-      int max_result_count);
+      int max_result_count,
+      const base::Callback<bool(const GURL&)>& url_filter);
 
   // Delete all the segment usage data which is older than the provided time
   // stamp.
   bool DeleteSegmentData(base::Time older_than);
 
   // Change the presentation id for the segment identified by |segment_id|
   bool SetSegmentPresentationIndex(SegmentID segment_id, int index);
 
   // Delete the segment currently using the provided url for representation.
   // This will also delete any associated segment usage data.
@@ skipping 14 matching lines @@
   // presentation table is removed entirely.
   bool MigratePresentationIndex();
 
  private:
   DISALLOW_COPY_AND_ASSIGN(VisitSegmentDatabase);
 };
 
 }  // namespace history
 
 #endif  // COMPONENTS_HISTORY_CORE_BROWSER_VISITSEGMENT_DATABASE_H_